[IndexFilters | Tabs] Add prefix
prop to IndexFilters
and readonly
prop to Tab
.
#11869
+553
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/web/issues/123422
The Markets team need some updates to the IndexFilters and Tabs components to support the new UI that they are building.
WHAT is this pull request doing?
This PR adds a
prefix
prop to the IndexFilters, which will render the ReactNode passed as the prop immediately to the left of the Tabs within the IndexFilters.It also adds a new
readonly
prop to aTab
within theTabs
component, which will give theTab
a differing visual treatment, and remove any interactivity from theTab
itself.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes