Add maps.ToKeys method #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrispappas
commented
Aug 23, 2022
chrispappas
commented
- also suppress gosec warnings for rand.Int() calls
- also suppress gosec warnings for rand.Int() calls
- since we already know the size, we can just pre-allocate and directly access the index
cuducos
suggested changes
Aug 24, 2022
| return out | ||
| } | ||
|
|
||
| func ToKeys[In any, Key comparable](arr map[Key]In) []Key { |
There was a problem hiding this comment.
I think we need to add the docs here, so our Go Packages page looks nice.
BTW the deprecated golint used to check for that, but the modern staticcheck only has checks for the wording of docs of exported functions, methods, variables.
There was a problem hiding this comment.
Oh man I totally didn't think to update the docs or the examples. Good call, thank you!
cuducos
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.