Attempt closing the connection on all expiry paths #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andremedeiros
requested review from
ibawt,
marc-barry,
fbogsany and
shivnagarajan
|
can you blurb the tl;dr in the description. |
fbogsany
approved these changes
Sep 18, 2017
|
I see thanks Andre, LGTM |
|
This was found to be causing issues with restarting resque scheduler and has "5 SDs attributable at least in part to this bug" (@xldenis). I'd love to try this out with Magellan on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection was marked as expired, we'd only close the existing one if the
Redialwas successful.With this change we clean it up regardless.