This repository has been archived by the owner on May 15, 2024. It is now read-only.
[ACTION REQUIRED] Remove deprecated values from service.yml #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![services-db[bot]](https://avatars.githubusercontent.com/in/116294?s=60&v=4){kind=small}
## Please review, fix any issues, and merge this PR. This PR removes the `slo`, `ci_url` and `uptime_url` keys from the `service.yml` file. We are rolling out this change across Shopify for all services. ### Why? - `slo`: SLOs are no longer required to be defined in `service.yml` file, instead, they should be created in Observe. It is highly recommended to define an availability SLO for your service. - `ci_url`: there's no need to override the CI pipeline url, the statistical CI information can be found in the `CI Metrics` tab in Services DB. - `uptime_url`: overriding uptime monitor url in `service.yml` is no longer supported, please go to Services DB page to define or link any uptime monitor. Please checkout [the document](https://service-docs.docs.shopify.io/getting_started/configuring_a_service) to find more information about the supported service properties. ### Where can I get help? The `service.yml` changes in this pull request were generated programmatically, so it may have accidentally deleted comments or aliases. Feel free to touch up the pull request to match whatever style you'd like before merging. If you have any questions, please reach out to #help-eng-infrastructure on Slack.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review, fix any issues, and merge this PR.
This PR removes the
slo,ci_urlanduptime_urlkeys from theservice.ymlfile. We are rolling out this change across Shopify for all services.Why?
slo: SLOs are no longer required to be defined inservice.ymlfile, instead, they should be created in Observe. It is highly recommended to define an availability SLO for your service.ci_url: there's no need to override the CI pipeline url, the statistical CI information can be found in theCI Metricstab in Services DB.uptime_url: overriding uptime monitor url inservice.ymlis no longer supported, please go to Services DB page to define or link any uptime monitor.Please checkout the document to find more information about the supported service properties.
Where can I get help?
The
service.ymlchanges in this pull request were generated programmatically, so it may have accidentally deleted comments or aliases.Feel free to touch up the pull request to match whatever style you'd like before merging. If you have any questions, please reach out to #help-eng-infrastructure on Slack.