Fix shopify theme dev to no longer fail when development themes expire in internationalized stores

[karreiro]

WHY are these changes introduced?

Fixes #5192

Users were facing the error above because internationalized stores return internationalized error messages in the new GQL API, which were not being handled as expected in the CLI.

WHAT is this pull request doing?

This PR changes the fetchTheme API to no longer abort or throw an error. API consumers are already handling the absence of the theme when the function returns undefined. Some abort the execution, but others create the necessary theme.

I've checked other possible similar scenarios, and I spotted no more occurrences of error messages being handled this way, so this PR should be enough.

How to test your changes?

• Update the language of your store to "Português (Brasil)"
• Run dev cd dawn
• Run shopify theme dev and get your development theme id
• Update ~/Library/Preferences/shopify-cli-development-theme-config-nodejs/config.json by appending 1 to your development theme id there (now, your development theme will no longer exist)
• Run dev cd dawn
• Run shopify theme dev
• Notice it just creates a new development theme

Before:

After:

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.12% (+0.01% 🔼)	8876/11815
🟡	Branches	70.29% (+0.03% 🔼)	4336/6169
🟡	Functions	75.04%	2324/3097
🟡	Lines	75.69% (+0.03% 🔼)	8392/11088

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / app-event-watcher.ts	93.83% (-1.23% 🔻)	86.49% (-2.7% 🔻)	90.48%	98.61%
🟡	... / api.ts	59.28% (-0.02% 🔻)	44.87% (-0.25% 🔻)	60%	60.76% (+0.02% 🔼)

Test suite run success

2005 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from 1a5aec2

[EvilGenius13]

Thank you for the quick fix! 🚀