-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create app with latest api version #5188
Conversation
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success2004 tests passing in 905 suites. Report generated by 🧪jest coverage report action from 49ef624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test that the API version is set from the API by default in CreatAppVars
?
packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts
Outdated
Show resolved
Hide resolved
b6c63c7
to
23f410f
Compare
23f410f
to
49ef624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests!
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2468
Creating an app with
USE_APP_MANAGEMENT_API=1 shopify app init
and then deploying the app fails because the default webhooks that come in the template require the2025-01
webhooks api version.This PR queries for the latest Webhook API Version before creating an app.
shopify(dev)> CoreApiVersioning.non_private_app_schedule.accessible_versions.map(&:handle)
=> ["2024-01", "2024-04", "2024-07", "2024-10", "2025-01", "2025-04", "unstable"]
To tophat:
export USE_APP_MANAGEMENT_API=1
shopify app init
shopify app deploy
Checklist