Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining refs to app ID when only API key is needed #5122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove remaining refs to app ID when only API key is needed #5122

wants to merge 1 commit into from

Conversation

amcaplan
Copy link
Contributor

Quick followup to #4918 removing an unnecessary param

@amcaplan amcaplan requested a review from a team as a code owner December 18, 2024 13:56
@github-actions GitHub Actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@amcaplan amcaplan requested a review from shauns December 18, 2024 13:56
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 75.23% 8806/11706
🟡 Branches 70.55% 4278/6064
🟡 Functions 75.02% 2304/3071
🟡 Lines
75.77% (+0.01% 🔼)
 8324/10986
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
 90.48% 98.61%

Test suite run success

1987 tests passing in 898 suites.

Report generated by 🧪jest coverage report action from 001d5a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

@shauns shauns Awaiting requested review from shauns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcaplan @isaacroldan