Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migration of product configuration link to cli #5055

Open
wants to merge 2 commits into
base: support-product-config-import-extensions
Choose a base branch
from

Conversation

lazirpascual
Copy link

@lazirpascual lazirpascual commented Dec 8, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/bundles-app/issues/2841

WHAT is this pull request doing?

Supports migrating dashboard-managed product configuration link extensions to become CLI managed as part of the dev and deploy commands.

How to test your changes?

Warning

🎩 wont work until https://github.com/Shopify/shopify/pull/558141 and other dependencies are merged

Follow the steps described in #5054 to import product configuration link extensions to CLI. Once imported run shopify app dev or shopify app deploy to migrate the extension to be CLI managed.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@lazirpascual lazirpascual requested a review from a team as a code owner December 8, 2024 08:03
@lazirpascual lazirpascual marked this pull request as draft December 8, 2024 08:03
Copy link
Contributor

github-actions bot commented Dec 8, 2024

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.71.4";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.71.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/cli.d.ts
@@ -16,13 +16,13 @@ interface RunCLIOptions {
  */
 export declare function runCLI(options: RunCLIOptions & {
     runInCreateMode?: boolean;
-}, launchCLI?: (options: {
+}, launchCLI: (options: {
     moduleURL: string;
 }) => Promise<void>, argv?: string[], env?: NodeJS.ProcessEnv, versions?: NodeJS.ProcessVersions): Promise<void>;
 /**
  * A function for create-x CLIs that automatically runs the "init" command.
  */
-export declare function runCreateCLI(options: RunCLIOptions, launchCLI?: (options: {
+export declare function runCreateCLI(options: RunCLIOptions, launchCLI: (options: {
     moduleURL: string;
 }) => Promise<void>, argv?: string[], env?: NodeJS.ProcessEnv, versions?: NodeJS.ProcessVersions): Promise<void>;
 /**

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.26% (-0.03% 🔻)
8778/11664
🟡 Branches
70.55% (-0.03% 🔻)
4279/6065
🟡 Functions 75.04% 2294/3057
🟡 Lines
75.82% (-0.03% 🔻)
8300/10947
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / identifiers-extensions.ts
72.39% (-3.01% 🔻)
66.2% (-2.46% 🔻)
100%
74.17% (-2.82% 🔻)

Test suite run success

1975 tests passing in 897 suites.

Report generated by 🧪jest coverage report action from bd4383d

@lazirpascual lazirpascual marked this pull request as ready for review December 9, 2024 15:07
@lazirpascual lazirpascual force-pushed the support-product-config-import-extensions branch from 2f2c708 to 732ca78 Compare December 11, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant