-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh session on 401 for graphQL requests #5001
Conversation
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/api.d.ts@@ -12,7 +12,7 @@ export declare function simpleRequestWithDebugLog<T extends {
export declare function retryAwareRequest<T extends {
headers: Headers;
status: number;
-}>({ request, url }: RequestOptions<T>, errorHandler?: (error: unknown, requestId: string | undefined) => unknown, retryOptions?: {
+}>({ request, url }: RequestOptions<T>, errorHandler?: (error: unknown, requestId: string | undefined) => unknown, unauthorizedHandler?: () => Promise<void>, retryOptions?: {
limitRetriesTo?: number;
defaultDelayMs?: number;
scheduleDelay: (fn: () => void, delay: number) => void;
packages/cli-kit/dist/public/node/api/graphql.d.ts@@ -21,12 +21,14 @@ interface GraphQLRequestBaseOptions<TResult> {
export type GraphQLRequestOptions<T> = GraphQLRequestBaseOptions<T> & {
query: RequestDocument;
variables?: Variables;
+ unauthorizedHandler?: () => Promise<void>;
};
export type GraphQLRequestDocOptions<TResult, TVariables> = GraphQLRequestBaseOptions<TResult> & {
query: TypedDocumentNode<TResult, TVariables> | TypedDocumentNode<TResult, Exact<{
[key: string]: never;
}>>;
variables?: TVariables;
+ unauthorizedHandler?: () => Promise<void>;
};
export interface GraphQLResponseOptions<T> {
handleErrors?: boolean;
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1968 tests passing in 892 suites. Report generated by 🧪jest coverage report action from 80ec997 |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cool approach, thank you for taking this on 😅
…it will be restored by #5001)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @catlee! LGTM and works as expected too :)
commit 4e3ffcc13a312904263f3eed3a5385983be18a8e Merge: a15cffc81d b711a00061 Author: Isaac Roldán <[email protected]> Date: Wed Dec 18 10:56:33 2024 +0000 Merge pull request #5112 from Shopify/12-16-add_try_catch_to_currentprocessisglobal_function Fix global CLI detection error handling commit a15cffc81dc874407a11720e3fec127653e00482 Merge: 3c13412fab 5258c521b3 Author: Ariel Caplan <[email protected]> Date: Tue Dec 17 10:22:37 2024 +0000 Merge pull request #4918 from Shopify/identify-app-by-api-key Allow identifying apps by API key, not ID commit 3c13412fabe377fd8c0bc2a037f2a054b6a55ae7 Merge: cb09e4d0dc c4593009c2 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 19:08:04 2024 +0000 Merge pull request #5056 from Shopify/fallback-to-github-when-not-on-spin Fall back to GitHub when repo is not on spin commit 5258c521b30bbe837e90c10d1b5107a844366948 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 16:43:45 2024 +0200 Handle not having app ID available for function schema operations commit 78662531af324f9309dabb3aa2f98e5185b2bb87 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 16:42:27 2024 +0200 Only search for apps by API key, not ID commit 8f0c2bbfa2e6681e0673b4d420bd70e9a5ffee21 Author: Ariel Caplan <[email protected]> Date: Mon Dec 9 21:30:54 2024 +0200 Remove copying mechanism which falsely suggests immutability In fact it's just a second reference to the same thing after the code changes in the previous commit. So it would be better to avoid suggesting that changes are safe. commit 66e62abbf3845c7a64ea3e65a7f9007619567940 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 15:59:41 2024 +0200 Rename for accuracy We may have API key rather than ID commit f9deee5df3d25a649fe14504555b8863177224e8 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 14:39:01 2024 +0200 Rename for consistency commit b9def1a6a18e16b1d9fc9a7dbdd944982348094f Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 14:33:07 2024 +0200 Remove unnecessary handling of app_id in TOML commit 63d77bc4318d5831eacec3a29c56aed37f3f85f4 Author: Ariel Caplan <[email protected]> Date: Mon Nov 25 17:25:31 2024 +0200 Allow identifying apps by API key, not ID commit cb09e4d0dc6c481053d86776230956848544a0e6 Merge: 720ad9c4b1 d7153b8e9f Author: Jeffrey Charles <[email protected]> Date: Mon Dec 16 16:09:58 2024 +0000 Merge pull request #5040 from Shopify/jc.use-shopify-functions-javy-plugin Use Shopify Functions Javy plugin instead of default Javy plugin commit 720ad9c4b1b370761822ec94d5b455bc31f65a7b Merge: 228e0a4ba3 24a149ff88 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 15:01:50 2024 +0000 Merge pull request #5115 from Shopify/12-16-catch_errors_when_building_functions Catch errors when building functions commit 24a149ff881a3b43545409c369011a7d1a917863 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 15:37:32 2024 +0100 Catch errors when building functions commit 228e0a4ba3ebba5e33d9c9a37f1f7d2a3270d161 Merge: 1d5dff4627 cae67c8d75 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 14:02:33 2024 +0000 Merge pull request #5073 from Shopify/12-10-group_app_config_updates_during_a_dev_session Group app config updates during a dev session commit 1d5dff46272bba24b4774fa0897bc7e7d3c04ce7 Merge: 17f19d1a13 2b64a86234 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 14:02:25 2024 +0000 Merge pull request #5111 from Shopify/update-esbuild-to-0.24 Update esbuild to 0.24 commit b711a000614ff0f9feee80cd3cc29cc824291949 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 15:01:33 2024 +0100 Update is-global.ts commit c4593009c211c088963be5e0706360ec4754665a Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 15:56:51 2024 +0200 Reraise exception commit 3e5dea0856375ca1ff3deae814c5df64f23e3b21 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 15:56:44 2024 +0200 Fetch slowly to avoid undiagnosable rate limiting issues commit 57edc7d361ae1cf8342dc01f031163ce40fc1503 Author: Ariel Caplan <[email protected]> Date: Sun Dec 8 12:31:06 2024 +0200 Fall back to GitHub when repo is not on spin commit 5bacf4c2a678ce316b02ce2f6d98d083a2f1fb6e Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 13:28:28 2024 +0100 Add try/catch to currentProcessIsGlobal function commit 2b64a862341139b47c84af341a304b11267400e3 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 11:37:45 2024 +0100 Update esbuild to 0.24 commit 17f19d1a13a40c4a2188a61fc15eebadf047b833 Merge: 011fc5067d 219b31cfc9 Author: Alex Bradley <[email protected]> Date: Fri Dec 13 21:15:54 2024 +0000 Merge pull request #5063 from Shopify/lopert.wasm-opt Download and run wasm-opt commit 011fc5067d69cd42d1e7e2ac7a939c4ce22466e9 Merge: 9f0c8838d5 4bda2922ae Author: Alfonso Noriega <[email protected]> Date: Fri Dec 13 15:51:29 2024 +0000 Merge pull request #5102 from Shopify/fix_subdomain_underscores_in_admin_link_import Fix undescores in subdomain target when importing legacy links commit 219b31cfc931fa772591819c49db181c4b7beae7 Author: Alex Bradley <[email protected]> Date: Thu Dec 12 09:19:06 2024 -0500 add debug log for runWasmOpt commit f47844ac3ad2f40826f12d53952866cc9ec318b5 Author: Alex Bradley <[email protected]> Date: Tue Dec 10 16:04:10 2024 -0500 remove flag, prefer config commit 3139db8724b3ec5a440f2ce73b8d46a51b1871d0 Author: Alex Bradley <[email protected]> Date: Tue Dec 10 15:59:36 2024 -0500 Use wasm_opt from config commit 62ad101203150b43d815d77b336e5b51a469049f Author: Alex Bradley <[email protected]> Date: Tue Dec 10 14:48:35 2024 -0500 add strip-debug arg for wasm-opt commit ad762ad57486c1f5677cef3212c5db61bbf613d8 Author: Alex Bradley <[email protected]> Date: Tue Dec 10 14:16:53 2024 -0500 add disable-wasm-opt flag commit b795a278fcc7e3649932855e21b9d6f3203fb1bb Author: Alex Bradley <[email protected]> Date: Tue Dec 10 11:06:11 2024 -0500 add wasm-opt build step test commit 87dc62e7a74582dc2884b8ff6bc6fb1b363bdc13 Author: Alex Bradley <[email protected]> Date: Mon Dec 9 16:40:50 2024 -0500 use exec over execSync commit 30a0c08584047e19ce24b9309f2b6525c31a10fa Author: Alex Bradley <[email protected]> Date: Mon Dec 9 16:14:31 2024 -0500 wasm opt binary test commit b403d970b3bbfd58a89d7df9befdaa465faa0b81 Author: Alex Bradley <[email protected]> Date: Mon Dec 9 13:58:49 2024 -0500 download and run wasm-opt commit 9f0c8838d5bb75c836274023f8b9bebb17a5440b Merge: 8e14ad8e12 bd13665847 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 13:57:44 2024 +0000 Merge pull request #5107 from Shopify/shauns/12-13-correctly_log_last_request_id_when_the_last_request_was_a_failure Correctly log last request ID when the last request was a failure commit 8e14ad8e1200c9a86da81707208661680f5cd365 Author: Gonzalo Riestra <[email protected]> Date: Fri Dec 13 12:41:00 2024 +0100 Revert "Postrelease stack for shipit" This reverts commit 5c1711abd38f9b76ff0a68c73e4f13fc488a257f. commit bd13665847beeeafaac42ca3bc629603e4206820 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 11:39:28 2024 +0000 Correctly log last request ID when the last request was a failure commit 5c1711abd38f9b76ff0a68c73e4f13fc488a257f Author: Gonzalo Riestra <[email protected]> Date: Fri Dec 13 12:37:55 2024 +0100 Postrelease stack for shipit commit d8c8998be2012e73ea96c0b01feb91c42e5b18ba Merge: e8179567b5 dea9a09d51 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 11:00:54 2024 +0000 Merge pull request #5082 from Shopify/shauns/12-11-fix_exception_raised_when_selectorcreateapp_fails_to_find_an_app Fix exception raised when selectOrCreateApp fails to find an app commit dea9a09d513a9a1d40bd254944612db0c69f1043 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:33:45 2024 +0000 Fix exception raised when selectOrCreateApp fails to find an app commit e8179567b5d25a4c689c727ee0101bd07e1af3d6 Merge: f7d281e9fe 8b072a194f Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 10:27:10 2024 +0000 Merge pull request #5093 from Shopify/shauns/12-12-check_that_shopify_shopify_function_has_a_run_module Check that @shopify/shopify_function has a `run` module commit 4bda2922aeed5ac5c48cfc64d1745d7a457973eb Author: Alfonso Noriega <[email protected]> Date: Fri Dec 13 10:47:33 2024 +0100 Fix undescores in subdomain target when importing legacy links commit 8b072a194f1e1cc4e115a36cf8047b6dd4101611 Author: Shaun Stanworth <[email protected]> Date: Thu Dec 12 09:52:08 2024 +0000 Check that @shopify/shopify_function has a `run` module commit f7d281e9fe3a2038a09525fbdce21753c474f6b7 Merge: ab2173f964 85bc807789 Author: Paulo Margarido <[email protected]> Date: Thu Dec 12 13:41:14 2024 +0000 Merge pull request #5059 from Shopify/pm/remove_unused_lockfiles Remove unused lockfiles after clone commit ab2173f9649247348d9afef03f799f6c598e99db Merge: ffd13e4b43 beab713acd Author: Alok Swamy <[email protected]> Date: Thu Dec 12 11:23:21 2024 +0000 Merge pull request #4782 from Shopify/feature/create-pull-metafields-cmd Create shopify theme metafields pull command commit ffd13e4b439903903309d109181f6630810209c4 Merge: e934b6d9f3 9545f7259a Author: Shaun Stanworth <[email protected]> Date: Thu Dec 12 09:32:39 2024 +0000 Merge pull request #5085 from Shopify/shauns/12-11-fix_an_error_when_user_enters_in_an_auto_complete Fix an error when user enters '\' in an auto complete commit e934b6d9f32684592f3d1afd4f06e196ab5bf5e1 Merge: 18a42fe2b4 865728de5a Author: Shaun Stanworth <[email protected]> Date: Thu Dec 12 08:52:53 2024 +0000 Merge pull request #5078 from Shopify/hl-bump-cli-hydrogen Bump cli-hydrogen to 9.0.3 commit 18a42fe2b47be2c701b2ce8ec24cb6ead1878f93 Merge: f95c1fcf34 ea27def4ee Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 20:13:58 2024 +0000 Merge pull request #5083 from Shopify/shauns/12-11-fix_exception_raised_when_gettomls_is_passed_a_non-directory Fix exception raised when getTomls is passed a non-directory commit 9545f7259aa5cf602ea77bec5eed4ba51015e0c7 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 20:07:47 2024 +0000 Fix an error when user enters '\' in an auto complete commit f95c1fcf3446df976734d4c2a04cc83f9fccdace Merge: 39e10174b3 f4a6f958b1 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:58:52 2024 +0000 Merge pull request #5084 from Shopify/shauns/12-11-fix_exceptions_raised_for_fs_level_errors Fix exceptions raised for FS level errors commit f4a6f958b19344a621fb8cb10c712359f2137af9 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:46:42 2024 +0000 Fix exceptions raised for FS level errors commit ea27def4ee8b489c8f1b45971087679c433eb02e Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:40:35 2024 +0000 Fix exception raised when getTomls is passed a non-directory commit 865728de5ae919c9d31d734d6a0a17a4ad6f3bec Author: Helen Lin <[email protected]> Date: Wed Dec 11 10:02:10 2024 -0800 update lock file commit cbfc36ca88fe507a4fd2d6a196a026ade1a784f3 Author: Helen Lin <[email protected]> Date: Wed Dec 11 09:58:21 2024 -0800 Bump cli-hydrogen commit beab713acd113d546a0b86db202f3eaa2353ee06 Author: Alok Swamy <[email protected]> Date: Mon Nov 4 15:45:17 2024 -0500 Create `shopify theme metafields pull` command commit 39e10174b380d2b129a23636e9f308eac67e861e Merge: dd0cc149d9 a92307dce8 Author: Gray Gilmore <[email protected]> Date: Tue Dec 10 22:34:00 2024 +0000 Merge pull request #5064 from Shopify/bump/theme-tools-2024-12-09 Bump Shopify/theme-tools packages commit a92307dce8d23ba0e5333707a1a34c0caf44e75a Author: Gray Gilmore <[email protected]> Date: Mon Dec 9 11:18:17 2024 -0800 Bump Shopify/theme-tools packages commit cae67c8d75f676b2eeadf17915deb1e525d4faf1 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 17:54:59 2024 +0100 Group app config updates during a dev session commit 85bc807789594b2e9637a6c1e10cb0ab90e90527 Author: Paulo Margarido <[email protected]> Date: Tue Dec 10 11:08:45 2024 -0500 Remove all lock files when manager is unknown commit d7153b8e9f59afb4b799d1a6f2ef4f08ee68826b Merge: 07f8394e4f dd0cc149d9 Author: Jeff Charles <[email protected]> Date: Tue Dec 10 11:09:45 2024 -0500 Merge branch 'main' into jc.use-shopify-functions-javy-plugin commit 07f8394e4f398c6064353ae30a531d0879144670 Author: Jeff Charles <[email protected]> Date: Tue Dec 10 11:06:35 2024 -0500 Use version constant in plugin name and path commit b4eda0235dc469019e9514b6e5ad1219f99de677 Author: Jeff Charles <[email protected]> Date: Tue Dec 10 11:02:51 2024 -0500 Update Shopify Functions to version with plugin commit 3b835f06c050d1d61080cc6702f6f7fc73ae4fe0 Author: Paulo Margarido <[email protected]> Date: Tue Dec 10 09:05:33 2024 -0500 Applying comments from code review commit dd0cc149d9da189bb82730ff2b15d2c63d7beff5 Merge: ed4f150544 4d722c64fc Author: Luke Hickin <[email protected]> Date: Tue Dec 10 13:09:23 2024 +0000 Merge pull request #4905 from Shopify/lukeh/theme-pull-git-dir Ensure git directory is clean when running `theme pull` commit ed4f150544c7232adb13fa1b822454fb26c647b9 Merge: 1c5559d85d c18109c272 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:41:13 2024 +0000 Merge pull request #5071 from Shopify/release-notes-3.72 Release notes for 3.72 commit c18109c27224ab94858693129c3b2c7b1a243563 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 11:33:45 2024 +0100 Release notes for 3.72 commit 1c5559d85df25bab1517c460a2564382388c1f19 Merge: cd1e758b76 63ad38687e Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:55:33 2024 +0100 Merge pull request #5069 from Shopify/changeset-release/main Version Packages - main commit 63ad38687e122966a2a5ccbca502a774e853b5a1 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Tue Dec 10 09:42:43 2024 +0000 Version Packages commit cd1e758b761b1f58e1b8f3d6295f03a85edf8574 Merge: 5beaf5faa9 178c17e820 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:40:11 2024 +0100 Merge pull request #5068 from Shopify/bump-minor-version-to-3.75 Bump minor version to 3.75 commit 178c17e820130ba8710dbbf6d7eeb0130197cd97 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:30:42 2024 +0100 Bump minor version commit 5beaf5faa97de45486bd0f39f5c776f35e1ec1bb Merge: 61911a8fef 7cf6a1f2fc Author: Jamie Guerrero <[email protected]> Date: Mon Dec 9 14:21:28 2024 -0500 Merge pull request #5023 from Shopify/changeset-release/main Version Packages - main commit 7cf6a1f2fc7477920291c2452f1acc0a66458e21 Author: Jamie Guerrero <[email protected]> Date: Mon Dec 9 14:10:13 2024 -0500 trigger CI commit 7b56b4b5fbe2726b4e22dcb8c868dc837b21abd3 Author: Paulo Margarido <[email protected]> Date: Mon Dec 9 13:06:10 2024 -0500 Applying comment from review commit 03fb93e3c9f233954fd4dddf8aa13b33c64ba8a0 Author: Paulo Margarido <[email protected]> Date: Mon Dec 9 11:22:18 2024 -0500 Remove unused lockfiles after clone commit 7b455195ad00a08b3773c1d2fd99586529f4c147 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Mon Dec 9 15:10:40 2024 +0000 Version Packages commit 61911a8fef7f3ed2c87afa20d6937e0455efcb3b Merge: 9299e907c2 44844a7752 Author: Jacob <[email protected]> Date: Mon Dec 9 15:01:35 2024 +0000 Merge pull request #5046 from Shopify/js.bump-function-runner bump function-runner to 6.4.0 commit 9299e907c2130f7d975d0b7bdb37ed89f79742d6 Merge: 8335447600 4e58f44685 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 19:48:00 2024 +0000 Merge pull request #5050 from Shopify/stable/3.71 Backport 3.71 patches commit 83354476003a539b2184d262a11011dd34e87225 Merge: 2711cc27b6 a077c930b9 Author: Cameron Barker <[email protected]> Date: Fri Dec 6 19:28:19 2024 +0000 Merge pull request #5041 from Shopify/1836-use-name-as-text Use name as link text insted of text property commit 4e58f446856cb6832f1a123f7454f43cb2733a69 Merge: 8cd1218b7f a473a44639 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 19:02:17 2024 +0000 Merge pull request #5049 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit a473a446391080d81ff91054650e6814241711db Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Fri Dec 6 18:58:14 2024 +0000 Version Packages commit 8cd1218b7f4e89e56d38a90739e3f8ca88b9300d Merge: 7835a90802 94953a671e Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 18:55:42 2024 +0000 Merge pull request #5048 from Shopify/gg-fix-empty-file-upload Allow empty theme files to be uploaded commit 94953a671ed48f0186834a7d989842abff2f1193 Author: Gray Gilmore <[email protected]> Date: Tue Dec 3 10:58:19 2024 -0800 Allow empty theme files to be uploaded commit 7835a90802a9650722cde46d743675869f72a065 Merge: 4dc64d7b09 b3233ffead Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 18:44:43 2024 +0000 Merge pull request #5047 from Shopify/shauns/12-06-make_launcher_option_for_cli_optional Make launcher option for CLI optional commit 2711cc27b6a16b6f60a2febafd02489f9f228d2c Merge: 98eb7bd649 07ff693af4 Author: James Meng <[email protected]> Date: Fri Dec 6 16:01:20 2024 +0000 Merge pull request #5042 from Shopify/jm/theme_blocks_ordering [Themes] Add support for block liquid files in theme partitioning commit b3233ffead08f53ab0a0e9a2f566b910de0e95fd Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 10:28:29 2024 +0000 Make launcher option for CLI optional commit 44844a7752040747950bc7d1e770e0316728ae4d Author: Jacob Steves <[email protected]> Date: Thu Dec 5 17:00:05 2024 -0500 bump function-runner to 6.4.0 commit a077c930b91e4d85050e97c981638c600c8d7f29 Author: Cameron Barker <[email protected]> Date: Thu Dec 5 16:54:27 2024 -0500 fixing tests commit 07ff693af4599519f5a4990ee689afd5ea0ec801 Author: James Meng <[email protected]> Date: Thu Dec 5 11:14:43 2024 -0800 Theme Upload: Add theme blocks to dependant files commit 98eb7bd6491b670fc866148a1dcae5fa0aa92a1e Merge: 2926cb0fd1 52ea1944ac Author: Mehdi Salemi <[email protected]> Date: Thu Dec 5 19:56:31 2024 +0000 Merge pull request #4875 from Shopify/ms.proto3 [ShopifyVM] Use Functions App Management API for Dev Dash commit a367e700e6c2918507fc53a49766676bff5ea3cd Author: James Meng <[email protected]> Date: Thu Dec 5 11:06:11 2024 -0800 Improve theme file partitioning to handle theme blocks commit aacd79875322ab66287f759615df0466a952e638 Author: Alfonso Noriega <[email protected]> Date: Thu Dec 5 19:47:49 2024 +0100 Use name as link text insted of text property commit adcce6d6642ab42ed1b25a331fc8c12d650a80b0 Author: Jeff Charles <[email protected]> Date: Thu Dec 5 11:46:43 2024 -0500 Use Shopify Functions Javy plugin instead of default Javy plugin commit 52ea1944acd2721cb79a4a28603676da24691e90 Author: Mehdi Salemi <[email protected]> Date: Mon Nov 18 16:06:03 2024 -0500 adds functions api client to fetch schema for dev dash commit 2926cb0fd145d48723c06eb7dd39dab0ebc29503 Merge: 673a588a1a d248695a34 Author: Isaac Roldán <[email protected]> Date: Thu Dec 5 10:32:45 2024 +0000 Merge pull request #5028 from Shopify/fix-function-drafts Fix function drafts commit 673a588a1a76445d1ecb5e7d794dee86d73e5986 Merge: c92d0a2b42 a4e15e1edd Author: Isaac Roldán <[email protected]> Date: Thu Dec 5 10:24:18 2024 +0000 Merge pull request #5027 from Shopify/increase-localization-file-size-limit Increase localization file size limit commit c92d0a2b422fb69acdb6e4350b94db9123064bf2 Merge: 7d2f856437 6797334f29 Author: Gray Gilmore <[email protected]> Date: Wed Dec 4 17:08:30 2024 +0000 Merge pull request #5015 from Shopify/gg-fix-empty-file-upload Allow empty theme files to be uploaded commit 4dc64d7b09926cf2d3f8ebc48cb90219101abc77 Merge: 0d7f9b5154 7d993b5028 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:57:20 2024 +0100 Merge pull request #5029 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit 7d993b5028513271a462d48617ebe69556d68cbd Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Wed Dec 4 16:55:11 2024 +0000 Version Packages commit 0d7f9b5154b16eff2545639a968629a00c39baa1 Merge: 6d1c64eb0a 05a1eda9eb Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:52:52 2024 +0100 Merge pull request #5022 from Shopify/update_context_to_target_mappings Update context to target mappings commit 6d1c64eb0ac9e5b41468eb26d4813b6a590c5276 Merge: 1312153877 7516cbde84 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:51:05 2024 +0100 Merge pull request #5026 from Shopify/increase-localization-file-size-limit-stable [stable] Increase extension locale file size limit commit 1312153877988e0697f2a92b3c40b5aaea7842e0 Merge: 38dc70c124 998ba06cef Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:50:53 2024 +0100 Merge pull request #5024 from Shopify/fix-function-drafts-stable [stable] Fix function drafts during `dev` commit d248695a34ce0cbb5170d8a50f14738130e42f56 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:32:05 2024 +0100 Remove changeset commit e08f0bae23c4884da5d5941498f9ca002bce11fd Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:03:07 2024 +0100 Fix tests commit 09f0c9f5cc4589cdb5421146e39a9cde8b815de4 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 15:44:11 2024 +0100 Fix function drafts not working during dev commit a4e15e1edd21e188b46eb8d6ed0a7e6fe8f0b524 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:19:35 2024 +0100 Update tests commit d80c4022fd8eee4af91c2f57a4f041608c631a32 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:11:59 2024 +0100 Increase file size limits for localization files commit 7516cbde84ac87425011ea6636c852bc0143089e Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:19:35 2024 +0100 Update tests commit 9767860ecae18db44e7d45771edc1f3f76512d06 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:11:59 2024 +0100 Increase file size limits for localization files commit 998ba06cefa6e58841b0d31d5fdf184b2ba073dd Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:03:07 2024 +0100 Fix tests commit 73eb727757f353342978453929a294a8ba124fdf Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 15:44:11 2024 +0100 Fix function drafts not working during dev commit d5b0856f783aafa53d132194e8ef587a99103926 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 15:23:33 2024 +0100 Increase file size limits for localization files commit 7d2f856437333f40513fb7de30a736600ab9ab4e Merge: c15413ea86 78cbc67c26 Author: Jeffrey Charles <[email protected]> Date: Wed Dec 4 14:04:37 2024 +0000 Merge pull request #5014 from Shopify/jc.download-plugin-ahead-of-time-with-javy Download Javy plugin with Javy binary commit 05a1eda9ebf6f1c2964760a71b602e9b5bedbb8b Author: Alfonso Noriega <[email protected]> Date: Wed Dec 4 13:43:53 2024 +0100 Added changeset commit 76893d242a4501ae10e3655fa940c587c61005ee Author: Alfonso Noriega <[email protected]> Date: Tue Dec 3 18:30:21 2024 +0100 Update context to target transform to match link targets commit c15413ea865ea0148c4c2cba0df8175d525e49b7 Merge: 084f555570 2fa6126867 Author: Alfonso Noriega <[email protected]> Date: Wed Dec 4 12:37:26 2024 +0000 Merge pull request #5013 from Shopify/update_mapping_from_context_to_targets Update context to target transform to match link targets commit 2fa6126867066fadcb56a78f81e2f5b424b8ab3a Author: Alfonso Noriega <[email protected]> Date: Tue Dec 3 18:30:21 2024 +0100 Update context to target transform to match link targets commit 38dc70c124f20fdb8ad72d7bf1d224f0ff6f5da8 Merge: c2bdeabc96 4501441b90 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 11:09:14 2024 +0100 Merge pull request #5018 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit 4501441b901dba3e01c40151ba1292c4242fca01 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Wed Dec 4 10:06:56 2024 +0000 Version Packages commit c2bdeabc96d72ddbe81a254cc7a7d949b9718f6f Merge: ce0ee89cb7 a395820e7b Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 11:04:27 2024 +0100 Merge pull request #5017 from Shopify/fix-not-found-in-check-command-safety-stable [stable] Fix dev for Ruby apps commit a395820e7b3c5cfa3479332cbb67807616db4743 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 10:54:58 2024 +0100 Add changeset commit 73d72944d32d1d34f2e37a2cb64b91d9973107f9 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 10:54:03 2024 +0100 Avoid errors on checkCommandSafety when the command is not found commit 084f555570080dfbc5243b02e184c1684736fc5b Merge: 4721974f42 f559cb05a4 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 09:45:26 2024 +0000 Merge pull request #4522 from Shopify/fix-not-found-in-check-command-safety Fix dev for Ruby apps commit f559cb05a48778df7c8065608b2b6818e3715095 Merge: a84792f30c 4721974f42 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 10:08:49 2024 +0100 Merge branch 'main' into fix-not-found-in-check-command-safety commit 6797334f2987919b0b3d8fdbdee8580f93d2cef2 Author: Gray Gilmore <[email protected]> Date: Tue Dec 3 11:02:07 2024 -0800 Update codeowners for themes API files commit 94a7d4ce4f33edbf0d48f772c3e3b2efebdab6b3 Author: Gray Gilmore <[email protected]> Date: Tue Dec 3 10:58:19 2024 -0800 Allow empty theme files to be uploaded commit 78cbc67c26d558a1021e0ac1da234ff86e394818 Author: Jeff Charles <[email protected]> Date: Tue Dec 3 12:40:48 2024 -0500 Download Javy plugin with Javy binary commit ce0ee89cb7cc4e40714c693e5ad9ea65f21d2567 Merge: 9b8c291dbb 869d5ac5fc Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 18:34:26 2024 +0100 Merge pull request #5012 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit 869d5ac5fce962f90c6148d2aa7d901ae6776d23 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Tue Dec 3 17:21:52 2024 +0000 Version Packages commit 9b8c291dbb889cc9f44f1277cf99b5e4796e9e4e Merge: e643396983 4b93d76290 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 18:19:22 2024 +0100 Merge pull request #5011 from Shopify/jc.set-overwrite-flag-stable Fix dest already exists error by setting overwrite flag on stable branch commit 4b93d76290447cd3c2f9a2aa29e3e3fcc1cccab2 Author: Jeff Charles <[email protected]> Date: Tue Dec 3 12:08:17 2024 -0500 Set override flag when moving downloaded binary commit 4721974f42e205e01bdba96c1c7841c74bca88d1 Merge: 55b65ecaa7 a930bd6148 Author: Jeffrey Charles <[email protected]> Date: Tue Dec 3 16:51:28 2024 +0000 Merge pull request #5009 from Shopify/jc.set-overwrite-flag Fix dest already exists error by setting overwrite flag commit a930bd6148ee9edec5ec0bb99728dba1533d9648 Author: Jeff Charles <[email protected]> Date: Tue Dec 3 11:20:38 2024 -0500 Fix dest already exists error by setting overwrite flag commit e643396983b225b716ddcac066f171136c1858a9 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 15:59:25 2024 +0100 Add stable/3.71 shipit configuration commit 87ba0d3f0477c2731b9ec8de59b6ffd8bb214217 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 15:58:58 2024 +0100 3.71 release notes commit 55b65ecaa75ebc71855b9cb4956b799e6178bdf3 Merge: 15b2a6fe18 0075a0e104 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 15:04:09 2024 +0100 Merge pull request #4844 from Shopify/changeset-release/main Version Packages - main commit 0075a0e104cb41eac15c2e7af37df027a79ac0f7 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 16:15:50 2024 +0000 Version Packages commit 15b2a6fe1881f96585b81a65d2417470f043a6d8 Merge: c202990cb9 80ec997d22 Author: Chris AtLee <[email protected]> Date: Mon Dec 2 16:06:48 2024 +0000 Merge pull request #5001 from Shopify/catlee/refresh_graphql Refresh session on 401 for graphQL requests commit c202990cb93a0df2b78dee5135477c39703e9acc Merge: 7fc88c3880 11fd136c57 Author: Guilherme Carreiro <[email protected]> Date: Mon Dec 2 15:54:39 2024 +0000 Merge pull request #4792 from Shopify/catlee/theme_files_put Use graphQL to upload theme files commit 11fd136c57014b8c200caefe12f05e0bd6abe79b Author: Guilherme Carreiro <[email protected]> Date: Mon Dec 2 15:44:56 2024 +0100 Remove the "refresh the session when 401 errors happen" commit 7fc88c38801674ca880502b87e60ddadb46d52fb Merge: 2af2272f47 b81ec3645e Author: Ariel Caplan <[email protected]> Date: Mon Dec 2 11:34:59 2024 +0000 Merge pull request #5003 from Shopify/centralize-app-management-gating Centralize gating of the App Management API commit b81ec3645efcfe7387bd8341b505a75abffb3eff Author: Ariel Caplan <[email protected]> Date: Sun Dec 1 23:35:09 2024 +0200 Centralize gating of the App Management API commit 80ec997d22ec7e9e96fe9450e3a05a2768da7122 Author: Chris AtLee <[email protected]> Date: Fri Nov 29 14:56:20 2024 -0500 Refresh session on 401 for graphQL requests commit 4d722c64fcfc15e7e9dbac5cb6807d8cee96d526 Author: Luke Hickin <[email protected]> Date: Thu Nov 21 15:25:13 2024 -0800 Ensure git directory is clean when running `theme pull` commit 2af2272f47688c5b49351f1702b2b68f07526e7b Merge: b70d526660 115718cdf5 Author: James Meng <[email protected]> Date: Fri Nov 29 17:26:46 2024 +0000 Merge pull request #4936 from Shopify/jm/clean-password-redirect [Themes] - Improve storefront password detection for password-protected shops with redirects commit b70d526660d5b7a3be3ed483ddfc24a8137efbf6 Merge: 8d21357d61 5b0d610259 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 15:44:16 2024 +0100 Improve multiple CLI installations warning performance (#4999) ### WHY are these changes introduced? Checking for multiple installed CLIs is very expensive. ### WHAT is this pull request doing? Wraps the `showMultipleCLIWarningIfNeeded` function call with `runAtMinimumInterval` to ensure the warning is only checked once every 24 hours. ### How to test your changes? 1. Having a local CLI and a global CLI 2. Run `shopify app info`, you should see a warning 3. Run it again: no warning -> command runs faster ### Measuring impact How do we know this change was effective? Please choose one: - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit 8d21357d615c49ae2daca7f83241b83f18672917 Merge: 55da34b1c5 d7cf5425c4 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 15:37:48 2024 +0100 Show `app init` success after loading the app (#4998) ### WHY are these changes introduced? App init shows the success message and then it still takes 1-2s to finish. ### WHAT is this pull request doing? Load the app BEFORE showing the success message. ### How to test your changes? 1. Run `shopify app init` to create a new app 2. Verify that after the success message, the command finishes immediately (it can still take up to 500ms to process analytics) ### Measuring impact How do we know this change was effective? Please choose one: - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix - [ ] Existing analytics will cater for this addition - [ ] PR includes analytics changes to measure impact ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit 55da34b1c58c144796dc07f5944b30c2ef7aa2f3 Merge: 4254118fa3 0442d42213 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 15:36:51 2024 +0100 Add proper support for gitignore in AppWatcher (#4917) ### WHY are these changes introduced? Fixes issues with file watching and extension creation detection during `app dev`. ### WHAT is this pull request doing? - Improves file watching by using the `ignore` package to properly handle `.gitignore` files in extensions. If an extension defines it, anything in it will be ignored by the app watcher. - Fixes extension creation mid-dev by updating the file watcher when the app is reloaded. ### How to test your changes? 1. Create a new app with some extensions 2. Add a `.gitignore` file to an extension directory 3. Start dev and verify: - File changes matching `.gitignore` patterns are properly ignored - New extensions are properly detected mid-dev ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible documentation changes commit 5b0d6102598d7114f67ab187439d5572538edf51 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 13:02:32 2024 +0100 Only check for multiple CLI once a day commit d7cf5425c418450f99b3f2e2e649a2b454202a68 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 11:42:22 2024 +0100 Show app init success after getting linked app commit 0442d422134354ca8127d18f88d7d529cb9b2ae5 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 17:57:11 2024 +0100 Update tests commit 642bebdc3d0552a522d73bbe3436591b158bbf01 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 17:26:48 2024 +0100 Update tests commit 80ab0cdaf5382bc6171d8c6888f9750446678fe9 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 16:22:35 2024 +0100 Add proper support for gitignore in AppWatcher commit 4915786a7c3d8a50c3beff86c748da69d29a5454 Author: Chris AtLee <[email protected]> Date: Mon Nov 4 17:57:58 2024 -0500 Use themeFilesUpsert graphQL instead of REST commit 4254118fa32c23040cd68009f02938637bce2c8e Merge: 3704940d47 33f713e06e Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 19:02:06 2024 +0000 Merge pull request #4886 from Shopify/bump/theme-tools-2024-11-19 Bump Shopify/theme-tools packages commit 33f713e06e1a50dfc9e6218d493f1432a0d82d15 Author: Charles-P. Clermont <[email protected]> Date: Tue Nov 19 16:02:45 2024 -0500 Bump theme tools packages commit 3704940d4768069b82fb75c5bac589f1eb04065a Merge: 2c6914b66e ec6b5e0e6d Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 18:24:32 2024 +0000 Merge pull request #4921 from Shopify/upload-artifact-v4 update to upload-artifact@v4 commit 2c6914b66ee8708cb5d8b64406a00a0256f116c8 Merge: 01ae0697b4 62c69bbf50 Author: Cédric Darne <[email protected]> Date: Thu Nov 28 17:48:53 2024 +0000 Merge pull request #4884 from Shopify/dev-dash-webhooks-api Introduce dev dash webhooks API commit 01ae0697b459f67f5cefda40e73346df92f95724 Merge: 8e761560e3 97117a0a8e Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 17:42:48 2024 +0000 Merge pull request #4696 from Shopify/checkout-ui-add-product-url-fix Fix the URL output to add a new product commit 62c69bbf50d131faca5d16770bbf8e0abdfd0b26 Author: Cedric Darne <[email protected]> Date: Thu Nov 28 12:42:48 2024 -0500 Fix lint commit 8e761560e3e4139825f320bd1e3ee15cb05af3a7 Merge: 7ad15fe64f 5d960d494a Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 18:36:38 2024 +0100 Merge pull request #4553 from Shopify/surma-patch-1 Remove reference to package.json commit 7ad15fe64f3fc82f7b72d97148cd1b4cd9509c09 Merge: 93a01390e6 e736a23ebc Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 17:21:28 2024 +0000 Merge pull request #4941 from Shopify/improve-issue-template Collapse verbose output by default in bug template commit 93a01390e60496f9dd39bdab80f341170452eeb6 Merge: f3d039650b b25d93a5eb Author: Guilherme Carreiro <[email protected]> Date: Thu Nov 28 17:12:46 2024 +0000 Merge pull request #4903 from AaronBarcos/fix/storefront-password-validation-localized-redirect Fix: Handle localized URLs in storefront password validation commit 115718cdf5d258a1e9ac3310c6f6b8c69a8d5f1a Author: James Meng <[email protected]> Date: Thu Nov 28 08:56:41 2024 -0800 Use URL constructor to grab redirect pathname commit f3d039650b532a22e8b95e7105a8d040a063935b Merge: caab0fcd66 af36a6a4ca Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 17:50:03 2024 +0100 Add client-id and reset as global flags (#4940) ### WHY are these changes introduced? Standardizes the handling of `client-id` and `reset` flags across all app commands by moving them to the shared app flags. ### WHAT is this pull request doing? - Moves `client-id` and `reset` flags to shared app flags - Updates all commands to use the shared flag implementations - Standardizes the usage of `client-id` and `reset` flags in `linkedAppContext` calls ### How to test your changes? 1. Run various app commands with `--client-id` flag 2. Run various app commands with `--reset` flag 3. Verify that both flags work consistently across all commands ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible documentation changes commit af36a6a4ca80b3ebf671ca2c84d29e97c5fa2428 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 14:23:34 2024 +0100 Add client-id and reset as global flags commit caab0fcd6693dde66a0791032e0d8e93c982ab40 Author: Shaun Stanworth <[email protected]> Date: Thu Nov 28 16:23:00 2024 +0000 Make a dependabot group for dev dependencies (#4994) ### WHY are these changes introduced? Updates Dependabot configuration to better organize dependency updates by grouping all dev dependencies together commit 86c1afe3e9a35a4559603d6fa94427a8d7320970 Author: Cedric Darne <[email protected]> Date: Thu Nov 28 11:08:13 2024 -0500 Update webhooks GQL schema branch commit ef45023b924c6bdd2658b1d9af6115bd62d951f0 Merge: 9f4fbc6489 26ceb5c47a Author: belalsj <[email protected]> Date: Thu Nov 28 15:49:03 2024 +0000 Merge pull request #4846 from Shopify/condition-with-manifest Enable multiple asset handling commit 26ceb5c47a3bbc59cd9a6be1e295266e35483280 Author: belalsj <[email protected]> Date: Wed Nov 20 11:50:00 2024 +0100 Enable multiple assets for extensions commit 9f4fbc6489372fedfca9a96e3aba1da42311577c Merge: 82b872fb4d ba794ba47a Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:12:55 2024 +0000 Merge pull request #4942 from Shopify/fix-dependabot-config Fix dependabot config commit ba794ba47a043bff680f5ac7b694e81aa6c5f0fb Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:31:07 2024 +0100 Include the packages subdirectories commit 69b8fe4850a7b12e7797216ac1f8eb883f15ff14 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:30:43 2024 +0100 Remove unneeded config for bundler commit e736a23ebc70f3e6d6b0dbcf6711638325f611f3 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:29:44 2024 +0100 Collapse verbose output by default in bug template commit 82b872fb4d9aff53031e0283366141ec6a2db7e2 Merge: 4e3f75759d 4d1d7e00f1 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 12:28:32 2024 +0000 Merge pull request #4939 from Shopify/revert-4931-upgrade-pnpm Revert "Upgrade pnpm to v9" commit 4d1d7e00f15e6c034c482872d550d3c6316e0879 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 13:16:15 2024 +0100 Revert "Upgrade pnpm to v9" commit 4e3f75759dc5a43eafe30da8cc3aee5211766f1e Merge: 66fe10cc58 80d2f2d9a1 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 13:13:04 2024 +0100 Refactor FileWatcher into a Class (#4916) ### WHY are these changes introduced? Refactors the file watcher implementation into a class-based structure to improve maintainability and testability of the file watching system used during app development. ### WHAT is this pull request doing? NO NEW FEATURES, mainly a refactor: - Converts the file watcher from a function-based to a class-based implementation: the new `FileWatcher` class - Adds proper dependency injection for testing - Introduces constants for configuration values - Updates tests to use the new class-based structure - Remove `micromatch`, it's not used anymore. ### How to test your changes? 1. Run `dev` command on an app with multiple extensions 2. Verify that file changes are properly detected and handled 3. Create new extensions and verify they are detected 4. Delete extensions and verify proper cleanup ### Measuring impact - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit 80d2f2d9a1cde58b3ec402264d022d2913257f6b Merge: 599e99b5da 66fe10cc58 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 11:16:49 2024 +0100 Merge branch 'main' into 11-25-refactor_filewatcher_into_a_class commit 599e99b5da72801e486f6f976b5a882e74069713 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 13:39:59 2024 +0100 Refactor FileWatcher into a Class commit 66fe10cc58250451633f935d1f5e7d65ef590fbe Merge: a2347d869b 504289fe52 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 09:52:42 2024 +0000 Merge pull request #4934 from Shopify/fix-dev-session-tests-memory-leak Fix AppWatcher tests memory leak commit a2347d869bf9436165a0486507cdd4338fc6e310 Merge: 8650ee09a6 a2cd0eb951 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 08:31:52 2024 +0000 Merge pull request #4931 from Shopify/upgrade-pnpm Upgrade pnpm to v9 commit 7017b9e31c8dca04bed008ae9064e67339e4afc8 Author: James Meng <[email protected]> Date: Wed Nov 27 16:02:35 2024 -0800 fix - Fix storefront password detection for password-protected shops with redirects commit ec6b5e0e6dca2a623e20863e1363b66a3975d5a1 Author: gracejychang <[email protected]> Date: Mon Nov 25 16:47:37 2024 -0800 update to upload-artifact@v4 commit 8650ee09a6e045b332e748ddfe39cffed8c7d866 Merge: 34ce42dd91 5107f4e805 Author: James Meng <[email protected]> Date: Wed Nov 27 17:55:07 2024 +0000 Merge pull request #4900 from Shopify/jm/strict_push Add --strict flag to theme push to enforce theme check before pushing commit 5107f4e80529c4e9e68303c62d029537cbf79491 Author: James Meng <[email protected]> Date: Thu Nov 21 15:10:04 2024 -0500 Update docs Changeset commit bad47dcd2ae0ac8d3893f4fc1517fbeda94d8172 Author: James Meng <[email protected]> Date: Thu Nov 21 11:45:07 2024 -0500 Update manifests commit c6c1406f2367bbad9b30fd1d3f8b0a1531c988d4 Author: James Meng <[email protected]> Date: Thu Nov 21 11:38:10 2024 -0500 Add and update tests Add JSON flag test commit 7dcd1a5ff599241154f6ae2012d61aaf0bd26d14 Author: James Meng <[email protected]> Date: Thu Nov 21 15:34:12 2024 -0500 [Refactor] Cleanup unused conditional commit 1a1b3b18f41a0ee8591624952f651e0c68f9fbce Author: James Meng <[email protected]> Date: Thu Nov 21 11:22:56 2024 -0500 refactor: extract theme check logic and improve strict mode handling commit 3feeac33fa1e0f25787fca0b679ae0414b694340 Author: James Meng <[email protected]> Date: Thu Nov 21 01:09:09 2024 -0500 Add --strict flag to theme push to enforce theme check before pushing commit 34ce42dd91d6a0837c191e57ee8bb69f5aa8ec26 Merge: a1af910e5e d00e41a0d2 Author: James Meng <[email protected]> Date: Wed Nov 27 17:02:10 2024 +0000 Merge pull request #4920 from Shopify/jamesmengo-patch-1 Update CODEOWNERS file patterns and add CLI README commit a2cd0eb951aaedf79f6387a324dbfc5dc2e45998 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 17:53:21 2024 +0100 Fix merge commit 984670ab60d5cffb078e5f717a878b72bbac5bb3 Merge: fdf0d22506 a1af910e5e Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 17:52:28 2024 +0100 Merge branch 'main' into upgrade-pnpm commit 504289fe529e7e2214c581340328aa20a31b3434 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 16:59:20 2024 +0100 Add extra mock commit bd38db39847e390f2c1a5a889175ba99e52ba58b Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 15:53:05 2024 +0100 abort watcher process after each test commit 3b6f7337a8d35f9ca4eadd751e3a411d4d540dee Merge: 274718e511 a1af910e5e Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 15:42:37 2024 +0100 Merge branch 'main' into fix-dev-session-tests-memory-leak commit a1af910e5e8c37e630b5fe3ca85a1d90fa77df34 Merge: a25af5a250 992bf9422e Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 15:32:28 2024 +0100 Improvements to App reload speed (#4924) ### WHY are these changes introduced? Improves app reloading performance by caching or avoiding expensive operations. ### WHAT is this pull request doing? - `~200ms` Introduces a new `reloadApp` function that reuses data from the previous app instance. - `~200ms` Caches JSON schema validators to avoid recompilation on each validation. - `~100ms` Replaces git ignore checking with a more efficient alternative: the `ignore` package - `~1200ms` Improves handling of CLI version warning to only check once per command execution. - Reduces the file-watcher debouncing time to 200ms Before this PR, time to reload an app: `1500-2000ms` New time: `~15-20ms` ❗ Improvement: `100x` ### How to test your changes? 1. Run `dev` on an app with multiple extensions using the app management API. 2. Make changes to extension configuration files. 3. Verify that reloading is faster and the app continues to function correctly. ### Measuring impact - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible documentation changes commit 992bf9422eb45e9ff5d5eb18060e15ea7e4b03d1 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 14:56:04 2024 +0100 Remove global didCheckForGlobalCLIWarning and update debounce to use leading commit f339b3cdeaa28299f69ce53bdec9094f61226d9d Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 13:46:46 2024 +0100 Add more tests for gitTracked commit 271acdb7ff3ab7026f7c868b912ab3164e06cadd Author: Isaac Roldán <[email protected]> Date: Tue Nov 26 12:59:34 2024 +0100 Loader improvements commit 43f0bd5d521ce247430c1ea539dfe98cc85b1fcc Author: Isaac Roldán <[email protected]> Date: Tue Nov 26 12:29:35 2024 +0100 Cache json schema validators commit a25af5a250f92389cd6dd78577d12534685f783d Merge: aecf7fe2bb 3fee076cd6 Author: Alfonso Noriega <[email protected]> Date: Wed Nov 27 14:14:52 2024 +0000 Merge pull request #4877 from Shopify/admin-link-import-transform-url-to-relative on import link extensions make absolute urls relative commit aecf7fe2bb11b8ad875f3686730f000e5d8af3c4 Merge: 55eef10137 9ed8458c4e Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:57:50 2024 +0000 Merge pull request #4930 from Shopify/skip-notifications-with-json-flag Skip notifications when using --json commit fdf0d22506f784ff9df5362e615f24dadeeedcfd Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:50:17 2024 +0100 Update workflows commit 1ac92cc9e406c0bf572755454eba0755e20aea12 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:38:45 2024 +0100 Update get-started.md commit b649a540e38a7b2345a119e6554a432410bd9a16 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:37:15 2024 +0100 Upgrade pnpm to v9 commit 9ed8458c4ec8a040c0aeadf3ae77f9ad57d8608b Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:25:36 2024 +0100 Fix lint issue commit 21d6b33287b3e9f3e10905102eeeae46f92737d3 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:04:25 2024 +0100 Keep a single reference of SHOPIFY_FLAG_JSON commit 2ca99425e212e720344240c257843fb5f0548419 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:23:09 2024 +0100 Update documentation commit 740d15d4df309b0108c16ab2450c763e147b99b6 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:19:37 2024 +0100 Refresh manifests commit 8e03a724d8beab1594d9b047a743c47d44782aec Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:10:36 2024 +0100 Add test commit 451c1769ab644ae0d579967723e0379ebcea47fd Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:05:15 2024 +0100 Update changeset commit db0391081e7d70e0696decff47192e5ebcc7bcd2 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:03:25 2024 +0100 Skip notifications when using SHOPIFY_FLAG_JSON commit 55eef10137cfab0b386748922f5c03bec9daddd0 Merge: 6a802151a6 0da3319aeb Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 12:56:35 2024 +0100 Fix initial draft update (#4929) ### WHY are these changes introduced? Addresses potential race conditions when pushing updates for draftable extensions in parallel. ### WHAT is this pull request doing? - Filters extension events to only process draftable extensions - Implements concurrent processing of extension updates using `Promise.all` ### How to test your changes? 1. Run dev with multiple draftable extensions (admin-action, theme) 2. Verify that we send initial drafts for every extension. ### Measuring impact - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit b47fdc347db7dcd12c80f571f572f27b8a804798 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:52:46 2024 +0100 Unify --json flag across commands commit e67cf3bf5fff4c269b9af3bb6569ac0dc8cad43b Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:52:10 2024 +0100 Skip notifications when using -j commit 5531731c115d9363fc870f721827036424937c84 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:29:48 2024 +0100 Add changeset commit 40d7edc1b562d1966e3de1bbdd5613c7c45dbb7d Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:29:10 2024 +0100 Skip notifications when using --json commit 0da3319aeb3bd8d37c625beecc65816ac3edb0c5 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 12:25:42 2024 +0100 Update draftable-extension.ts commit 274718e511ab3d1678ecaf9ec3ba83936fa2ec74 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 12:19:24 2024 +0100 Abort AppWatcher after every test commit 4b4c8756e0870068bfaeb9fe60acfe1322ce9989 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 11:28:31 2024 +0100 Fix initial draft update commit 3fee076cd6f6a0340521889197c118c734bda37d Author: Alfonso Noriega <[email protected]> Date: Mon Nov 25 15:53:46 2024 +0100 Add missing update imported flag for admin link and subscription link commit e6746ac5372e79fe09a5662dd813c9f547186525 Author: Alfonso Noriega <[email protected]> Date: Mon Nov 25 15:20:08 2024 +0100 Remove All option if only one is imported commit d56b534dd3e898110dcae2be2fb12eee2afed7f9 Author: Alfonso Noriega <[email protected]> Date: Tue Nov 19 11:34:57 2024 +0100 on import of legacy link extensions make absolute urls relative for embedded apps commit b25d93a5eb8c94c3045d790a1681b8a9ffc0dac3 Author: AaronBarcos <[email protected]> Date: Wed Nov 27 10:25:41 2024 +0100 Fix lint error: handle unexpected errors in catch block commit ff994c34d370fe732d7f41c8677546520e8da489 Author: AaronBarcos <[email protected]> Date: Wed Nov 27 10:12:27 2024 +0100 Add changeset for password validation fix commit 5ac28c0c89187e3fed052b988a1149e6552d9799 Author: aaronbarcos <[email protected]> Date: Thu Nov 21 11:27:18 2024 +0100 Enhance storefront password validation to check redirect URL origin commit 501fadf8e98de8e0e1f5fa308f6d93a35fce3946 Author: aaronbarcos <[email protected]> Date: Thu Nov 21 11:25:59 2024 +0100 Add tests for storefront password validation with localized URL and origin checks commit fe1b92e862faa60a0427da574cd34ee5110b9ea8 Author: Cedric Darne <[email protected]> Date: Tue Nov 26 17:02:08 2024 -0500 Add the OrgId to all webhooks API calls The Organization ID is required by the new API to check the various token permissions commit d00e41a0d23e49a0ea7e534a12b132bdfe493ad1 Author: James Meng <[email protected]> Date: Mon Nov 25 12:07:03 2024 -0800 Update CODEOWNERS - Add docs to Advanced edits allow-list - Add subfolders to `docs-shopify.dev` - Update README.md Motivation: Self serve for PR's like https://github.com/Shopify/cli/pull/4900/files where we add a new flag commit 6a802151a6bc01932631c363e6a790b23adc058f Merge: 04d6a2e6ce af2a07d082 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 18:54:12 2024 +0000 Merge pull request #4926 from Shopify/message-field Use message field properly commit af2a07d082eb148abd8253a111547d91d2bb7635 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 19:11:12 2024 +0200 Use message field properly commit 04d6a2e6ce6f08a3a746b903d387d2d6f41592c4 Merge: ecb0b9d103 928fbe72b4 Author: Shaun Stanworth <[email protected]> Date: Tue Nov 26 18:07:33 2024 +0000 Merge pull request #4923 from Shopify/fix-knip Remove micromatch dependency commit ebca8acc260931d6dd2a1a65395b38ec917feaf9 Author: Cedric Darne <[email protected]> Date: Mon Nov 25 18:12:56 2024 -0500 sendSampleWebhook better null field handling commit c49eb8ac5045a315987cb035c98783e36ff34ca9 Author: Cedric Darne <[email protected]> Date: Mon Nov 25 12:19:50 2024 -0500 Simplify the PublicApiVersions query commit d567c2f246146771ba925a3166baf8433f5a699d Author: Cedric Darne <[email protected]> Date: Fri Nov 15 16:30:50 2024 -0500 Introduce dev dash webhooks API commit 928fbe72b418d528a966fd45cfab60f6b0ca6102 Author: Isaac Roldán <[email protected]> Date: Tue Nov 26 10:33:15 2024 +0100 fix-knip commit 97117a0a8ef3bea19eb8a6b0700bd8a47a92970a Author: Nick Wesselman <[email protected]> Date: Mon Oct 21 11:45:14 2024 -0400 Normalize URL and use hyperlinks commit 6b063d17c1464c9fa36c4ec9ddeeab343f7069eb Author: Nick Wesselman <[email protected]> Date: Mon Oct 21 10:36:40 2024 -0400 Fix the URL output to add a new product commit 5d960d494a32ff3735ce34fa92d3835448e8c997 Author: Surma <[email protected]> Date: Tue Oct 1 14:36:33 2024 +0100 Remove reference to package.json commit a84792f30c81dedd2ff0c6444bb37d8cc6f741e9 Author: Gonzalo Riestra <[email protected]> Date: Wed Sep 25 17:32:11 2024 +0200 Add tests commit 07cd7c1b1388f34c914561539c8b6db7b19a4ba3 Author: Ariel Caplan <[email protected]> Date: Wed Sep 25 14:49:27 2024 +0300 Fix check to enforce everything commit 9c9b8df4ed578f548d222645d023d730e5e9fa88 Author: Gonzalo Riestra <[email protected]> Date: Wed Sep 25 12:32:56 2024 +0200 Avoid errors on checkCommandSafety when the command is not found
commit 4e3ffcc13a312904263f3eed3a5385983be18a8e Merge: a15cffc81d b711a00061 Author: Isaac Roldán <[email protected]> Date: Wed Dec 18 10:56:33 2024 +0000 Merge pull request #5112 from Shopify/12-16-add_try_catch_to_currentprocessisglobal_function Fix global CLI detection error handling commit a15cffc81dc874407a11720e3fec127653e00482 Merge: 3c13412fab 5258c521b3 Author: Ariel Caplan <[email protected]> Date: Tue Dec 17 10:22:37 2024 +0000 Merge pull request #4918 from Shopify/identify-app-by-api-key Allow identifying apps by API key, not ID commit 3c13412fabe377fd8c0bc2a037f2a054b6a55ae7 Merge: cb09e4d0dc c4593009c2 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 19:08:04 2024 +0000 Merge pull request #5056 from Shopify/fallback-to-github-when-not-on-spin Fall back to GitHub when repo is not on spin commit 5258c521b30bbe837e90c10d1b5107a844366948 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 16:43:45 2024 +0200 Handle not having app ID available for function schema operations commit 78662531af324f9309dabb3aa2f98e5185b2bb87 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 16:42:27 2024 +0200 Only search for apps by API key, not ID commit 8f0c2bbfa2e6681e0673b4d420bd70e9a5ffee21 Author: Ariel Caplan <[email protected]> Date: Mon Dec 9 21:30:54 2024 +0200 Remove copying mechanism which falsely suggests immutability In fact it's just a second reference to the same thing after the code changes in the previous commit. So it would be better to avoid suggesting that changes are safe. commit 66e62abbf3845c7a64ea3e65a7f9007619567940 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 15:59:41 2024 +0200 Rename for accuracy We may have API key rather than ID commit f9deee5df3d25a649fe14504555b8863177224e8 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 14:39:01 2024 +0200 Rename for consistency commit b9def1a6a18e16b1d9fc9a7dbdd944982348094f Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 14:33:07 2024 +0200 Remove unnecessary handling of app_id in TOML commit 63d77bc4318d5831eacec3a29c56aed37f3f85f4 Author: Ariel Caplan <[email protected]> Date: Mon Nov 25 17:25:31 2024 +0200 Allow identifying apps by API key, not ID commit cb09e4d0dc6c481053d86776230956848544a0e6 Merge: 720ad9c4b1 d7153b8e9f Author: Jeffrey Charles <[email protected]> Date: Mon Dec 16 16:09:58 2024 +0000 Merge pull request #5040 from Shopify/jc.use-shopify-functions-javy-plugin Use Shopify Functions Javy plugin instead of default Javy plugin commit 720ad9c4b1b370761822ec94d5b455bc31f65a7b Merge: 228e0a4ba3 24a149ff88 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 15:01:50 2024 +0000 Merge pull request #5115 from Shopify/12-16-catch_errors_when_building_functions Catch errors when building functions commit 24a149ff881a3b43545409c369011a7d1a917863 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 15:37:32 2024 +0100 Catch errors when building functions commit 228e0a4ba3ebba5e33d9c9a37f1f7d2a3270d161 Merge: 1d5dff4627 cae67c8d75 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 14:02:33 2024 +0000 Merge pull request #5073 from Shopify/12-10-group_app_config_updates_during_a_dev_session Group app config updates during a dev session commit 1d5dff46272bba24b4774fa0897bc7e7d3c04ce7 Merge: 17f19d1a13 2b64a86234 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 14:02:25 2024 +0000 Merge pull request #5111 from Shopify/update-esbuild-to-0.24 Update esbuild to 0.24 commit b711a000614ff0f9feee80cd3cc29cc824291949 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 15:01:33 2024 +0100 Update is-global.ts commit c4593009c211c088963be5e0706360ec4754665a Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 15:56:51 2024 +0200 Reraise exception commit 3e5dea0856375ca1ff3deae814c5df64f23e3b21 Author: Ariel Caplan <[email protected]> Date: Mon Dec 16 15:56:44 2024 +0200 Fetch slowly to avoid undiagnosable rate limiting issues commit 57edc7d361ae1cf8342dc01f031163ce40fc1503 Author: Ariel Caplan <[email protected]> Date: Sun Dec 8 12:31:06 2024 +0200 Fall back to GitHub when repo is not on spin commit 5bacf4c2a678ce316b02ce2f6d98d083a2f1fb6e Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 13:28:28 2024 +0100 Add try/catch to currentProcessIsGlobal function commit 2b64a862341139b47c84af341a304b11267400e3 Author: Isaac Roldán <[email protected]> Date: Mon Dec 16 11:37:45 2024 +0100 Update esbuild to 0.24 commit 17f19d1a13a40c4a2188a61fc15eebadf047b833 Merge: 011fc5067d 219b31cfc9 Author: Alex Bradley <[email protected]> Date: Fri Dec 13 21:15:54 2024 +0000 Merge pull request #5063 from Shopify/lopert.wasm-opt Download and run wasm-opt commit 011fc5067d69cd42d1e7e2ac7a939c4ce22466e9 Merge: 9f0c8838d5 4bda2922ae Author: Alfonso Noriega <[email protected]> Date: Fri Dec 13 15:51:29 2024 +0000 Merge pull request #5102 from Shopify/fix_subdomain_underscores_in_admin_link_import Fix undescores in subdomain target when importing legacy links commit 219b31cfc931fa772591819c49db181c4b7beae7 Author: Alex Bradley <[email protected]> Date: Thu Dec 12 09:19:06 2024 -0500 add debug log for runWasmOpt commit f47844ac3ad2f40826f12d53952866cc9ec318b5 Author: Alex Bradley <[email protected]> Date: Tue Dec 10 16:04:10 2024 -0500 remove flag, prefer config commit 3139db8724b3ec5a440f2ce73b8d46a51b1871d0 Author: Alex Bradley <[email protected]> Date: Tue Dec 10 15:59:36 2024 -0500 Use wasm_opt from config commit 62ad101203150b43d815d77b336e5b51a469049f Author: Alex Bradley <[email protected]> Date: Tue Dec 10 14:48:35 2024 -0500 add strip-debug arg for wasm-opt commit ad762ad57486c1f5677cef3212c5db61bbf613d8 Author: Alex Bradley <[email protected]> Date: Tue Dec 10 14:16:53 2024 -0500 add disable-wasm-opt flag commit b795a278fcc7e3649932855e21b9d6f3203fb1bb Author: Alex Bradley <[email protected]> Date: Tue Dec 10 11:06:11 2024 -0500 add wasm-opt build step test commit 87dc62e7a74582dc2884b8ff6bc6fb1b363bdc13 Author: Alex Bradley <[email protected]> Date: Mon Dec 9 16:40:50 2024 -0500 use exec over execSync commit 30a0c08584047e19ce24b9309f2b6525c31a10fa Author: Alex Bradley <[email protected]> Date: Mon Dec 9 16:14:31 2024 -0500 wasm opt binary test commit b403d970b3bbfd58a89d7df9befdaa465faa0b81 Author: Alex Bradley <[email protected]> Date: Mon Dec 9 13:58:49 2024 -0500 download and run wasm-opt commit 9f0c8838d5bb75c836274023f8b9bebb17a5440b Merge: 8e14ad8e12 bd13665847 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 13:57:44 2024 +0000 Merge pull request #5107 from Shopify/shauns/12-13-correctly_log_last_request_id_when_the_last_request_was_a_failure Correctly log last request ID when the last request was a failure commit 8e14ad8e1200c9a86da81707208661680f5cd365 Author: Gonzalo Riestra <[email protected]> Date: Fri Dec 13 12:41:00 2024 +0100 Revert "Postrelease stack for shipit" This reverts commit 5c1711abd38f9b76ff0a68c73e4f13fc488a257f. commit bd13665847beeeafaac42ca3bc629603e4206820 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 11:39:28 2024 +0000 Correctly log last request ID when the last request was a failure commit 5c1711abd38f9b76ff0a68c73e4f13fc488a257f Author: Gonzalo Riestra <[email protected]> Date: Fri Dec 13 12:37:55 2024 +0100 Postrelease stack for shipit commit d8c8998be2012e73ea96c0b01feb91c42e5b18ba Merge: e8179567b5 dea9a09d51 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 11:00:54 2024 +0000 Merge pull request #5082 from Shopify/shauns/12-11-fix_exception_raised_when_selectorcreateapp_fails_to_find_an_app Fix exception raised when selectOrCreateApp fails to find an app commit dea9a09d513a9a1d40bd254944612db0c69f1043 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:33:45 2024 +0000 Fix exception raised when selectOrCreateApp fails to find an app commit e8179567b5d25a4c689c727ee0101bd07e1af3d6 Merge: f7d281e9fe 8b072a194f Author: Shaun Stanworth <[email protected]> Date: Fri Dec 13 10:27:10 2024 +0000 Merge pull request #5093 from Shopify/shauns/12-12-check_that_shopify_shopify_function_has_a_run_module Check that @shopify/shopify_function has a `run` module commit 4bda2922aeed5ac5c48cfc64d1745d7a457973eb Author: Alfonso Noriega <[email protected]> Date: Fri Dec 13 10:47:33 2024 +0100 Fix undescores in subdomain target when importing legacy links commit 8b072a194f1e1cc4e115a36cf8047b6dd4101611 Author: Shaun Stanworth <[email protected]> Date: Thu Dec 12 09:52:08 2024 +0000 Check that @shopify/shopify_function has a `run` module commit f7d281e9fe3a2038a09525fbdce21753c474f6b7 Merge: ab2173f964 85bc807789 Author: Paulo Margarido <[email protected]> Date: Thu Dec 12 13:41:14 2024 +0000 Merge pull request #5059 from Shopify/pm/remove_unused_lockfiles Remove unused lockfiles after clone commit ab2173f9649247348d9afef03f799f6c598e99db Merge: ffd13e4b43 beab713acd Author: Alok Swamy <[email protected]> Date: Thu Dec 12 11:23:21 2024 +0000 Merge pull request #4782 from Shopify/feature/create-pull-metafields-cmd Create shopify theme metafields pull command commit ffd13e4b439903903309d109181f6630810209c4 Merge: e934b6d9f3 9545f7259a Author: Shaun Stanworth <[email protected]> Date: Thu Dec 12 09:32:39 2024 +0000 Merge pull request #5085 from Shopify/shauns/12-11-fix_an_error_when_user_enters_in_an_auto_complete Fix an error when user enters '\' in an auto complete commit e934b6d9f32684592f3d1afd4f06e196ab5bf5e1 Merge: 18a42fe2b4 865728de5a Author: Shaun Stanworth <[email protected]> Date: Thu Dec 12 08:52:53 2024 +0000 Merge pull request #5078 from Shopify/hl-bump-cli-hydrogen Bump cli-hydrogen to 9.0.3 commit 18a42fe2b47be2c701b2ce8ec24cb6ead1878f93 Merge: f95c1fcf34 ea27def4ee Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 20:13:58 2024 +0000 Merge pull request #5083 from Shopify/shauns/12-11-fix_exception_raised_when_gettomls_is_passed_a_non-directory Fix exception raised when getTomls is passed a non-directory commit 9545f7259aa5cf602ea77bec5eed4ba51015e0c7 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 20:07:47 2024 +0000 Fix an error when user enters '\' in an auto complete commit f95c1fcf3446df976734d4c2a04cc83f9fccdace Merge: 39e10174b3 f4a6f958b1 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:58:52 2024 +0000 Merge pull request #5084 from Shopify/shauns/12-11-fix_exceptions_raised_for_fs_level_errors Fix exceptions raised for FS level errors commit f4a6f958b19344a621fb8cb10c712359f2137af9 Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:46:42 2024 +0000 Fix exceptions raised for FS level errors commit ea27def4ee8b489c8f1b45971087679c433eb02e Author: Shaun Stanworth <[email protected]> Date: Wed Dec 11 19:40:35 2024 +0000 Fix exception raised when getTomls is passed a non-directory commit 865728de5ae919c9d31d734d6a0a17a4ad6f3bec Author: Helen Lin <[email protected]> Date: Wed Dec 11 10:02:10 2024 -0800 update lock file commit cbfc36ca88fe507a4fd2d6a196a026ade1a784f3 Author: Helen Lin <[email protected]> Date: Wed Dec 11 09:58:21 2024 -0800 Bump cli-hydrogen commit beab713acd113d546a0b86db202f3eaa2353ee06 Author: Alok Swamy <[email protected]> Date: Mon Nov 4 15:45:17 2024 -0500 Create `shopify theme metafields pull` command commit 39e10174b380d2b129a23636e9f308eac67e861e Merge: dd0cc149d9 a92307dce8 Author: Gray Gilmore <[email protected]> Date: Tue Dec 10 22:34:00 2024 +0000 Merge pull request #5064 from Shopify/bump/theme-tools-2024-12-09 Bump Shopify/theme-tools packages commit a92307dce8d23ba0e5333707a1a34c0caf44e75a Author: Gray Gilmore <[email protected]> Date: Mon Dec 9 11:18:17 2024 -0800 Bump Shopify/theme-tools packages commit cae67c8d75f676b2eeadf17915deb1e525d4faf1 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 17:54:59 2024 +0100 Group app config updates during a dev session commit 85bc807789594b2e9637a6c1e10cb0ab90e90527 Author: Paulo Margarido <[email protected]> Date: Tue Dec 10 11:08:45 2024 -0500 Remove all lock files when manager is unknown commit d7153b8e9f59afb4b799d1a6f2ef4f08ee68826b Merge: 07f8394e4f dd0cc149d9 Author: Jeff Charles <[email protected]> Date: Tue Dec 10 11:09:45 2024 -0500 Merge branch 'main' into jc.use-shopify-functions-javy-plugin commit 07f8394e4f398c6064353ae30a531d0879144670 Author: Jeff Charles <[email protected]> Date: Tue Dec 10 11:06:35 2024 -0500 Use version constant in plugin name and path commit b4eda0235dc469019e9514b6e5ad1219f99de677 Author: Jeff Charles <[email protected]> Date: Tue Dec 10 11:02:51 2024 -0500 Update Shopify Functions to version with plugin commit 3b835f06c050d1d61080cc6702f6f7fc73ae4fe0 Author: Paulo Margarido <[email protected]> Date: Tue Dec 10 09:05:33 2024 -0500 Applying comments from code review commit dd0cc149d9da189bb82730ff2b15d2c63d7beff5 Merge: ed4f150544 4d722c64fc Author: Luke Hickin <[email protected]> Date: Tue Dec 10 13:09:23 2024 +0000 Merge pull request #4905 from Shopify/lukeh/theme-pull-git-dir Ensure git directory is clean when running `theme pull` commit ed4f150544c7232adb13fa1b822454fb26c647b9 Merge: 1c5559d85d c18109c272 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:41:13 2024 +0000 Merge pull request #5071 from Shopify/release-notes-3.72 Release notes for 3.72 commit c18109c27224ab94858693129c3b2c7b1a243563 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 11:33:45 2024 +0100 Release notes for 3.72 commit 1c5559d85df25bab1517c460a2564382388c1f19 Merge: cd1e758b76 63ad38687e Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:55:33 2024 +0100 Merge pull request #5069 from Shopify/changeset-release/main Version Packages - main commit 63ad38687e122966a2a5ccbca502a774e853b5a1 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Tue Dec 10 09:42:43 2024 +0000 Version Packages commit cd1e758b761b1f58e1b8f3d6295f03a85edf8574 Merge: 5beaf5faa9 178c17e820 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:40:11 2024 +0100 Merge pull request #5068 from Shopify/bump-minor-version-to-3.75 Bump minor version to 3.75 commit 178c17e820130ba8710dbbf6d7eeb0130197cd97 Author: Isaac Roldán <[email protected]> Date: Tue Dec 10 10:30:42 2024 +0100 Bump minor version commit 5beaf5faa97de45486bd0f39f5c776f35e1ec1bb Merge: 61911a8fef 7cf6a1f2fc Author: Jamie Guerrero <[email protected]> Date: Mon Dec 9 14:21:28 2024 -0500 Merge pull request #5023 from Shopify/changeset-release/main Version Packages - main commit 7cf6a1f2fc7477920291c2452f1acc0a66458e21 Author: Jamie Guerrero <[email protected]> Date: Mon Dec 9 14:10:13 2024 -0500 trigger CI commit 7b56b4b5fbe2726b4e22dcb8c868dc837b21abd3 Author: Paulo Margarido <[email protected]> Date: Mon Dec 9 13:06:10 2024 -0500 Applying comment from review commit 03fb93e3c9f233954fd4dddf8aa13b33c64ba8a0 Author: Paulo Margarido <[email protected]> Date: Mon Dec 9 11:22:18 2024 -0500 Remove unused lockfiles after clone commit 7b455195ad00a08b3773c1d2fd99586529f4c147 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Mon Dec 9 15:10:40 2024 +0000 Version Packages commit 61911a8fef7f3ed2c87afa20d6937e0455efcb3b Merge: 9299e907c2 44844a7752 Author: Jacob <[email protected]> Date: Mon Dec 9 15:01:35 2024 +0000 Merge pull request #5046 from Shopify/js.bump-function-runner bump function-runner to 6.4.0 commit 9299e907c2130f7d975d0b7bdb37ed89f79742d6 Merge: 8335447600 4e58f44685 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 19:48:00 2024 +0000 Merge pull request #5050 from Shopify/stable/3.71 Backport 3.71 patches commit 83354476003a539b2184d262a11011dd34e87225 Merge: 2711cc27b6 a077c930b9 Author: Cameron Barker <[email protected]> Date: Fri Dec 6 19:28:19 2024 +0000 Merge pull request #5041 from Shopify/1836-use-name-as-text Use name as link text insted of text property commit 4e58f446856cb6832f1a123f7454f43cb2733a69 Merge: 8cd1218b7f a473a44639 Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 19:02:17 2024 +0000 Merge pull request #5049 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit a473a446391080d81ff91054650e6814241711db Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Fri Dec 6 18:58:14 2024 +0000 Version Packages commit 8cd1218b7f4e89e56d38a90739e3f8ca88b9300d Merge: 7835a90802 94953a671e Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 18:55:42 2024 +0000 Merge pull request #5048 from Shopify/gg-fix-empty-file-upload Allow empty theme files to be uploaded commit 94953a671ed48f0186834a7d989842abff2f1193 Author: Gray Gilmore <[email protected]> Date: Tue Dec 3 10:58:19 2024 -0800 Allow empty theme files to be uploaded commit 7835a90802a9650722cde46d743675869f72a065 Merge: 4dc64d7b09 b3233ffead Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 18:44:43 2024 +0000 Merge pull request #5047 from Shopify/shauns/12-06-make_launcher_option_for_cli_optional Make launcher option for CLI optional commit 2711cc27b6a16b6f60a2febafd02489f9f228d2c Merge: 98eb7bd649 07ff693af4 Author: James Meng <[email protected]> Date: Fri Dec 6 16:01:20 2024 +0000 Merge pull request #5042 from Shopify/jm/theme_blocks_ordering [Themes] Add support for block liquid files in theme partitioning commit b3233ffead08f53ab0a0e9a2f566b910de0e95fd Author: Shaun Stanworth <[email protected]> Date: Fri Dec 6 10:28:29 2024 +0000 Make launcher option for CLI optional commit 44844a7752040747950bc7d1e770e0316728ae4d Author: Jacob Steves <[email protected]> Date: Thu Dec 5 17:00:05 2024 -0500 bump function-runner to 6.4.0 commit a077c930b91e4d85050e97c981638c600c8d7f29 Author: Cameron Barker <[email protected]> Date: Thu Dec 5 16:54:27 2024 -0500 fixing tests commit 07ff693af4599519f5a4990ee689afd5ea0ec801 Author: James Meng <[email protected]> Date: Thu Dec 5 11:14:43 2024 -0800 Theme Upload: Add theme blocks to dependant files commit 98eb7bd6491b670fc866148a1dcae5fa0aa92a1e Merge: 2926cb0fd1 52ea1944ac Author: Mehdi Salemi <[email protected]> Date: Thu Dec 5 19:56:31 2024 +0000 Merge pull request #4875 from Shopify/ms.proto3 [ShopifyVM] Use Functions App Management API for Dev Dash commit a367e700e6c2918507fc53a49766676bff5ea3cd Author: James Meng <[email protected]> Date: Thu Dec 5 11:06:11 2024 -0800 Improve theme file partitioning to handle theme blocks commit aacd79875322ab66287f759615df0466a952e638 Author: Alfonso Noriega <[email protected]> Date: Thu Dec 5 19:47:49 2024 +0100 Use name as link text insted of text property commit adcce6d6642ab42ed1b25a331fc8c12d650a80b0 Author: Jeff Charles <[email protected]> Date: Thu Dec 5 11:46:43 2024 -0500 Use Shopify Functions Javy plugin instead of default Javy plugin commit 52ea1944acd2721cb79a4a28603676da24691e90 Author: Mehdi Salemi <[email protected]> Date: Mon Nov 18 16:06:03 2024 -0500 adds functions api client to fetch schema for dev dash commit 2926cb0fd145d48723c06eb7dd39dab0ebc29503 Merge: 673a588a1a d248695a34 Author: Isaac Roldán <[email protected]> Date: Thu Dec 5 10:32:45 2024 +0000 Merge pull request #5028 from Shopify/fix-function-drafts Fix function drafts commit 673a588a1a76445d1ecb5e7d794dee86d73e5986 Merge: c92d0a2b42 a4e15e1edd Author: Isaac Roldán <[email protected]> Date: Thu Dec 5 10:24:18 2024 +0000 Merge pull request #5027 from Shopify/increase-localization-file-size-limit Increase localization file size limit commit c92d0a2b422fb69acdb6e4350b94db9123064bf2 Merge: 7d2f856437 6797334f29 Author: Gray Gilmore <[email protected]> Date: Wed Dec 4 17:08:30 2024 +0000 Merge pull request #5015 from Shopify/gg-fix-empty-file-upload Allow empty theme files to be uploaded commit 4dc64d7b09926cf2d3f8ebc48cb90219101abc77 Merge: 0d7f9b5154 7d993b5028 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:57:20 2024 +0100 Merge pull request #5029 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit 7d993b5028513271a462d48617ebe69556d68cbd Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Wed Dec 4 16:55:11 2024 +0000 Version Packages commit 0d7f9b5154b16eff2545639a968629a00c39baa1 Merge: 6d1c64eb0a 05a1eda9eb Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:52:52 2024 +0100 Merge pull request #5022 from Shopify/update_context_to_target_mappings Update context to target mappings commit 6d1c64eb0ac9e5b41468eb26d4813b6a590c5276 Merge: 1312153877 7516cbde84 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:51:05 2024 +0100 Merge pull request #5026 from Shopify/increase-localization-file-size-limit-stable [stable] Increase extension locale file size limit commit 1312153877988e0697f2a92b3c40b5aaea7842e0 Merge: 38dc70c124 998ba06cef Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:50:53 2024 +0100 Merge pull request #5024 from Shopify/fix-function-drafts-stable [stable] Fix function drafts during `dev` commit d248695a34ce0cbb5170d8a50f14738130e42f56 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:32:05 2024 +0100 Remove changeset commit e08f0bae23c4884da5d5941498f9ca002bce11fd Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:03:07 2024 +0100 Fix tests commit 09f0c9f5cc4589cdb5421146e39a9cde8b815de4 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 15:44:11 2024 +0100 Fix function drafts not working during dev commit a4e15e1edd21e188b46eb8d6ed0a7e6fe8f0b524 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:19:35 2024 +0100 Update tests commit d80c4022fd8eee4af91c2f57a4f041608c631a32 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:11:59 2024 +0100 Increase file size limits for localization files commit 7516cbde84ac87425011ea6636c852bc0143089e Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:19:35 2024 +0100 Update tests commit 9767860ecae18db44e7d45771edc1f3f76512d06 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:11:59 2024 +0100 Increase file size limits for localization files commit 998ba06cefa6e58841b0d31d5fdf184b2ba073dd Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 17:03:07 2024 +0100 Fix tests commit 73eb727757f353342978453929a294a8ba124fdf Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 15:44:11 2024 +0100 Fix function drafts not working during dev commit d5b0856f783aafa53d132194e8ef587a99103926 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 15:23:33 2024 +0100 Increase file size limits for localization files commit 7d2f856437333f40513fb7de30a736600ab9ab4e Merge: c15413ea86 78cbc67c26 Author: Jeffrey Charles <[email protected]> Date: Wed Dec 4 14:04:37 2024 +0000 Merge pull request #5014 from Shopify/jc.download-plugin-ahead-of-time-with-javy Download Javy plugin with Javy binary commit 05a1eda9ebf6f1c2964760a71b602e9b5bedbb8b Author: Alfonso Noriega <[email protected]> Date: Wed Dec 4 13:43:53 2024 +0100 Added changeset commit 76893d242a4501ae10e3655fa940c587c61005ee Author: Alfonso Noriega <[email protected]> Date: Tue Dec 3 18:30:21 2024 +0100 Update context to target transform to match link targets commit c15413ea865ea0148c4c2cba0df8175d525e49b7 Merge: 084f555570 2fa6126867 Author: Alfonso Noriega <[email protected]> Date: Wed Dec 4 12:37:26 2024 +0000 Merge pull request #5013 from Shopify/update_mapping_from_context_to_targets Update context to target transform to match link targets commit 2fa6126867066fadcb56a78f81e2f5b424b8ab3a Author: Alfonso Noriega <[email protected]> Date: Tue Dec 3 18:30:21 2024 +0100 Update context to target transform to match link targets commit 38dc70c124f20fdb8ad72d7bf1d224f0ff6f5da8 Merge: c2bdeabc96 4501441b90 Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 11:09:14 2024 +0100 Merge pull request #5018 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit 4501441b901dba3e01c40151ba1292c4242fca01 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Wed Dec 4 10:06:56 2024 +0000 Version Packages commit c2bdeabc96d72ddbe81a254cc7a7d949b9718f6f Merge: ce0ee89cb7 a395820e7b Author: Isaac Roldán <[email protected]> Date: Wed Dec 4 11:04:27 2024 +0100 Merge pull request #5017 from Shopify/fix-not-found-in-check-command-safety-stable [stable] Fix dev for Ruby apps commit a395820e7b3c5cfa3479332cbb67807616db4743 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 10:54:58 2024 +0100 Add changeset commit 73d72944d32d1d34f2e37a2cb64b91d9973107f9 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 10:54:03 2024 +0100 Avoid errors on checkCommandSafety when the command is not found commit 084f555570080dfbc5243b02e184c1684736fc5b Merge: 4721974f42 f559cb05a4 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 09:45:26 2024 +0000 Merge pull request #4522 from Shopify/fix-not-found-in-check-command-safety Fix dev for Ruby apps commit f559cb05a48778df7c8065608b2b6818e3715095 Merge: a84792f30c 4721974f42 Author: Gonzalo Riestra <[email protected]> Date: Wed Dec 4 10:08:49 2024 +0100 Merge branch 'main' into fix-not-found-in-check-command-safety commit 6797334f2987919b0b3d8fdbdee8580f93d2cef2 Author: Gray Gilmore <[email protected]> Date: Tue Dec 3 11:02:07 2024 -0800 Update codeowners for themes API files commit 94a7d4ce4f33edbf0d48f772c3e3b2efebdab6b3 Author: Gray Gilmore <[email protected]> Date: Tue Dec 3 10:58:19 2024 -0800 Allow empty theme files to be uploaded commit 78cbc67c26d558a1021e0ac1da234ff86e394818 Author: Jeff Charles <[email protected]> Date: Tue Dec 3 12:40:48 2024 -0500 Download Javy plugin with Javy binary commit ce0ee89cb7cc4e40714c693e5ad9ea65f21d2567 Merge: 9b8c291dbb 869d5ac5fc Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 18:34:26 2024 +0100 Merge pull request #5012 from Shopify/changeset-release/stable/3.71 Version Packages - stable/3.71 commit 869d5ac5fce962f90c6148d2aa7d901ae6776d23 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Tue Dec 3 17:21:52 2024 +0000 Version Packages commit 9b8c291dbb889cc9f44f1277cf99b5e4796e9e4e Merge: e643396983 4b93d76290 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 18:19:22 2024 +0100 Merge pull request #5011 from Shopify/jc.set-overwrite-flag-stable Fix dest already exists error by setting overwrite flag on stable branch commit 4b93d76290447cd3c2f9a2aa29e3e3fcc1cccab2 Author: Jeff Charles <[email protected]> Date: Tue Dec 3 12:08:17 2024 -0500 Set override flag when moving downloaded binary commit 4721974f42e205e01bdba96c1c7841c74bca88d1 Merge: 55b65ecaa7 a930bd6148 Author: Jeffrey Charles <[email protected]> Date: Tue Dec 3 16:51:28 2024 +0000 Merge pull request #5009 from Shopify/jc.set-overwrite-flag Fix dest already exists error by setting overwrite flag commit a930bd6148ee9edec5ec0bb99728dba1533d9648 Author: Jeff Charles <[email protected]> Date: Tue Dec 3 11:20:38 2024 -0500 Fix dest already exists error by setting overwrite flag commit e643396983b225b716ddcac066f171136c1858a9 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 15:59:25 2024 +0100 Add stable/3.71 shipit configuration commit 87ba0d3f0477c2731b9ec8de59b6ffd8bb214217 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 15:58:58 2024 +0100 3.71 release notes commit 55b65ecaa75ebc71855b9cb4956b799e6178bdf3 Merge: 15b2a6fe18 0075a0e104 Author: Isaac Roldán <[email protected]> Date: Tue Dec 3 15:04:09 2024 +0100 Merge pull request #4844 from Shopify/changeset-release/main Version Packages - main commit 0075a0e104cb41eac15c2e7af37df027a79ac0f7 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 16:15:50 2024 +0000 Version Packages commit 15b2a6fe1881f96585b81a65d2417470f043a6d8 Merge: c202990cb9 80ec997d22 Author: Chris AtLee <[email protected]> Date: Mon Dec 2 16:06:48 2024 +0000 Merge pull request #5001 from Shopify/catlee/refresh_graphql Refresh session on 401 for graphQL requests commit c202990cb93a0df2b78dee5135477c39703e9acc Merge: 7fc88c3880 11fd136c57 Author: Guilherme Carreiro <[email protected]> Date: Mon Dec 2 15:54:39 2024 +0000 Merge pull request #4792 from Shopify/catlee/theme_files_put Use graphQL to upload theme files commit 11fd136c57014b8c200caefe12f05e0bd6abe79b Author: Guilherme Carreiro <[email protected]> Date: Mon Dec 2 15:44:56 2024 +0100 Remove the "refresh the session when 401 errors happen" commit 7fc88c38801674ca880502b87e60ddadb46d52fb Merge: 2af2272f47 b81ec3645e Author: Ariel Caplan <[email protected]> Date: Mon Dec 2 11:34:59 2024 +0000 Merge pull request #5003 from Shopify/centralize-app-management-gating Centralize gating of the App Management API commit b81ec3645efcfe7387bd8341b505a75abffb3eff Author: Ariel Caplan <[email protected]> Date: Sun Dec 1 23:35:09 2024 +0200 Centralize gating of the App Management API commit 80ec997d22ec7e9e96fe9450e3a05a2768da7122 Author: Chris AtLee <[email protected]> Date: Fri Nov 29 14:56:20 2024 -0500 Refresh session on 401 for graphQL requests commit 4d722c64fcfc15e7e9dbac5cb6807d8cee96d526 Author: Luke Hickin <[email protected]> Date: Thu Nov 21 15:25:13 2024 -0800 Ensure git directory is clean when running `theme pull` commit 2af2272f47688c5b49351f1702b2b68f07526e7b Merge: b70d526660 115718cdf5 Author: James Meng <[email protected]> Date: Fri Nov 29 17:26:46 2024 +0000 Merge pull request #4936 from Shopify/jm/clean-password-redirect [Themes] - Improve storefront password detection for password-protected shops with redirects commit b70d526660d5b7a3be3ed483ddfc24a8137efbf6 Merge: 8d21357d61 5b0d610259 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 15:44:16 2024 +0100 Improve multiple CLI installations warning performance (#4999) ### WHY are these changes introduced? Checking for multiple installed CLIs is very expensive. ### WHAT is this pull request doing? Wraps the `showMultipleCLIWarningIfNeeded` function call with `runAtMinimumInterval` to ensure the warning is only checked once every 24 hours. ### How to test your changes? 1. Having a local CLI and a global CLI 2. Run `shopify app info`, you should see a warning 3. Run it again: no warning -> command runs faster ### Measuring impact How do we know this change was effective? Please choose one: - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit 8d21357d615c49ae2daca7f83241b83f18672917 Merge: 55da34b1c5 d7cf5425c4 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 15:37:48 2024 +0100 Show `app init` success after loading the app (#4998) ### WHY are these changes introduced? App init shows the success message and then it still takes 1-2s to finish. ### WHAT is this pull request doing? Load the app BEFORE showing the success message. ### How to test your changes? 1. Run `shopify app init` to create a new app 2. Verify that after the success message, the command finishes immediately (it can still take up to 500ms to process analytics) ### Measuring impact How do we know this change was effective? Please choose one: - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix - [ ] Existing analytics will cater for this addition - [ ] PR includes analytics changes to measure impact ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit 55da34b1c58c144796dc07f5944b30c2ef7aa2f3 Merge: 4254118fa3 0442d42213 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 15:36:51 2024 +0100 Add proper support for gitignore in AppWatcher (#4917) ### WHY are these changes introduced? Fixes issues with file watching and extension creation detection during `app dev`. ### WHAT is this pull request doing? - Improves file watching by using the `ignore` package to properly handle `.gitignore` files in extensions. If an extension defines it, anything in it will be ignored by the app watcher. - Fixes extension creation mid-dev by updating the file watcher when the app is reloaded. ### How to test your changes? 1. Create a new app with some extensions 2. Add a `.gitignore` file to an extension directory 3. Start dev and verify: - File changes matching `.gitignore` patterns are properly ignored - New extensions are properly detected mid-dev ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible documentation changes commit 5b0d6102598d7114f67ab187439d5572538edf51 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 13:02:32 2024 +0100 Only check for multiple CLI once a day commit d7cf5425c418450f99b3f2e2e649a2b454202a68 Author: Isaac Roldán <[email protected]> Date: Fri Nov 29 11:42:22 2024 +0100 Show app init success after getting linked app commit 0442d422134354ca8127d18f88d7d529cb9b2ae5 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 17:57:11 2024 +0100 Update tests commit 642bebdc3d0552a522d73bbe3436591b158bbf01 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 17:26:48 2024 +0100 Update tests commit 80ab0cdaf5382bc6171d8c6888f9750446678fe9 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 16:22:35 2024 +0100 Add proper support for gitignore in AppWatcher commit 4915786a7c3d8a50c3beff86c748da69d29a5454 Author: Chris AtLee <[email protected]> Date: Mon Nov 4 17:57:58 2024 -0500 Use themeFilesUpsert graphQL instead of REST commit 4254118fa32c23040cd68009f02938637bce2c8e Merge: 3704940d47 33f713e06e Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 19:02:06 2024 +0000 Merge pull request #4886 from Shopify/bump/theme-tools-2024-11-19 Bump Shopify/theme-tools packages commit 33f713e06e1a50dfc9e6218d493f1432a0d82d15 Author: Charles-P. Clermont <[email protected]> Date: Tue Nov 19 16:02:45 2024 -0500 Bump theme tools packages commit 3704940d4768069b82fb75c5bac589f1eb04065a Merge: 2c6914b66e ec6b5e0e6d Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 18:24:32 2024 +0000 Merge pull request #4921 from Shopify/upload-artifact-v4 update to upload-artifact@v4 commit 2c6914b66ee8708cb5d8b64406a00a0256f116c8 Merge: 01ae0697b4 62c69bbf50 Author: Cédric Darne <[email protected]> Date: Thu Nov 28 17:48:53 2024 +0000 Merge pull request #4884 from Shopify/dev-dash-webhooks-api Introduce dev dash webhooks API commit 01ae0697b459f67f5cefda40e73346df92f95724 Merge: 8e761560e3 97117a0a8e Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 17:42:48 2024 +0000 Merge pull request #4696 from Shopify/checkout-ui-add-product-url-fix Fix the URL output to add a new product commit 62c69bbf50d131faca5d16770bbf8e0abdfd0b26 Author: Cedric Darne <[email protected]> Date: Thu Nov 28 12:42:48 2024 -0500 Fix lint commit 8e761560e3e4139825f320bd1e3ee15cb05af3a7 Merge: 7ad15fe64f 5d960d494a Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 18:36:38 2024 +0100 Merge pull request #4553 from Shopify/surma-patch-1 Remove reference to package.json commit 7ad15fe64f3fc82f7b72d97148cd1b4cd9509c09 Merge: 93a01390e6 e736a23ebc Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 17:21:28 2024 +0000 Merge pull request #4941 from Shopify/improve-issue-template Collapse verbose output by default in bug template commit 93a01390e60496f9dd39bdab80f341170452eeb6 Merge: f3d039650b b25d93a5eb Author: Guilherme Carreiro <[email protected]> Date: Thu Nov 28 17:12:46 2024 +0000 Merge pull request #4903 from AaronBarcos/fix/storefront-password-validation-localized-redirect Fix: Handle localized URLs in storefront password validation commit 115718cdf5d258a1e9ac3310c6f6b8c69a8d5f1a Author: James Meng <[email protected]> Date: Thu Nov 28 08:56:41 2024 -0800 Use URL constructor to grab redirect pathname commit f3d039650b532a22e8b95e7105a8d040a063935b Merge: caab0fcd66 af36a6a4ca Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 17:50:03 2024 +0100 Add client-id and reset as global flags (#4940) ### WHY are these changes introduced? Standardizes the handling of `client-id` and `reset` flags across all app commands by moving them to the shared app flags. ### WHAT is this pull request doing? - Moves `client-id` and `reset` flags to shared app flags - Updates all commands to use the shared flag implementations - Standardizes the usage of `client-id` and `reset` flags in `linkedAppContext` calls ### How to test your changes? 1. Run various app commands with `--client-id` flag 2. Run various app commands with `--reset` flag 3. Verify that both flags work consistently across all commands ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible documentation changes commit af36a6a4ca80b3ebf671ca2c84d29e97c5fa2428 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 14:23:34 2024 +0100 Add client-id and reset as global flags commit caab0fcd6693dde66a0791032e0d8e93c982ab40 Author: Shaun Stanworth <[email protected]> Date: Thu Nov 28 16:23:00 2024 +0000 Make a dependabot group for dev dependencies (#4994) ### WHY are these changes introduced? Updates Dependabot configuration to better organize dependency updates by grouping all dev dependencies together commit 86c1afe3e9a35a4559603d6fa94427a8d7320970 Author: Cedric Darne <[email protected]> Date: Thu Nov 28 11:08:13 2024 -0500 Update webhooks GQL schema branch commit ef45023b924c6bdd2658b1d9af6115bd62d951f0 Merge: 9f4fbc6489 26ceb5c47a Author: belalsj <[email protected]> Date: Thu Nov 28 15:49:03 2024 +0000 Merge pull request #4846 from Shopify/condition-with-manifest Enable multiple asset handling commit 26ceb5c47a3bbc59cd9a6be1e295266e35483280 Author: belalsj <[email protected]> Date: Wed Nov 20 11:50:00 2024 +0100 Enable multiple assets for extensions commit 9f4fbc6489372fedfca9a96e3aba1da42311577c Merge: 82b872fb4d ba794ba47a Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:12:55 2024 +0000 Merge pull request #4942 from Shopify/fix-dependabot-config Fix dependabot config commit ba794ba47a043bff680f5ac7b694e81aa6c5f0fb Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:31:07 2024 +0100 Include the packages subdirectories commit 69b8fe4850a7b12e7797216ac1f8eb883f15ff14 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:30:43 2024 +0100 Remove unneeded config for bundler commit e736a23ebc70f3e6d6b0dbcf6711638325f611f3 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 15:29:44 2024 +0100 Collapse verbose output by default in bug template commit 82b872fb4d9aff53031e0283366141ec6a2db7e2 Merge: 4e3f75759d 4d1d7e00f1 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 12:28:32 2024 +0000 Merge pull request #4939 from Shopify/revert-4931-upgrade-pnpm Revert "Upgrade pnpm to v9" commit 4d1d7e00f15e6c034c482872d550d3c6316e0879 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 13:16:15 2024 +0100 Revert "Upgrade pnpm to v9" commit 4e3f75759dc5a43eafe30da8cc3aee5211766f1e Merge: 66fe10cc58 80d2f2d9a1 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 13:13:04 2024 +0100 Refactor FileWatcher into a Class (#4916) ### WHY are these changes introduced? Refactors the file watcher implementation into a class-based structure to improve maintainability and testability of the file watching system used during app development. ### WHAT is this pull request doing? NO NEW FEATURES, mainly a refactor: - Converts the file watcher from a function-based to a class-based implementation: the new `FileWatcher` class - Adds proper dependency injection for testing - Introduces constants for configuration values - Updates tests to use the new class-based structure - Remove `micromatch`, it's not used anymore. ### How to test your changes? 1. Run `dev` command on an app with multiple extensions 2. Verify that file changes are properly detected and handled 3. Create new extensions and verify they are detected 4. Delete extensions and verify proper cleanup ### Measuring impact - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit 80d2f2d9a1cde58b3ec402264d022d2913257f6b Merge: 599e99b5da 66fe10cc58 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 11:16:49 2024 +0100 Merge branch 'main' into 11-25-refactor_filewatcher_into_a_class commit 599e99b5da72801e486f6f976b5a882e74069713 Author: Isaac Roldán <[email protected]> Date: Mon Nov 25 13:39:59 2024 +0100 Refactor FileWatcher into a Class commit 66fe10cc58250451633f935d1f5e7d65ef590fbe Merge: a2347d869b 504289fe52 Author: Isaac Roldán <[email protected]> Date: Thu Nov 28 09:52:42 2024 +0000 Merge pull request #4934 from Shopify/fix-dev-session-tests-memory-leak Fix AppWatcher tests memory leak commit a2347d869bf9436165a0486507cdd4338fc6e310 Merge: 8650ee09a6 a2cd0eb951 Author: Gonzalo Riestra <[email protected]> Date: Thu Nov 28 08:31:52 2024 +0000 Merge pull request #4931 from Shopify/upgrade-pnpm Upgrade pnpm to v9 commit 7017b9e31c8dca04bed008ae9064e67339e4afc8 Author: James Meng <[email protected]> Date: Wed Nov 27 16:02:35 2024 -0800 fix - Fix storefront password detection for password-protected shops with redirects commit ec6b5e0e6dca2a623e20863e1363b66a3975d5a1 Author: gracejychang <[email protected]> Date: Mon Nov 25 16:47:37 2024 -0800 update to upload-artifact@v4 commit 8650ee09a6e045b332e748ddfe39cffed8c7d866 Merge: 34ce42dd91 5107f4e805 Author: James Meng <[email protected]> Date: Wed Nov 27 17:55:07 2024 +0000 Merge pull request #4900 from Shopify/jm/strict_push Add --strict flag to theme push to enforce theme check before pushing commit 5107f4e80529c4e9e68303c62d029537cbf79491 Author: James Meng <[email protected]> Date: Thu Nov 21 15:10:04 2024 -0500 Update docs Changeset commit bad47dcd2ae0ac8d3893f4fc1517fbeda94d8172 Author: James Meng <[email protected]> Date: Thu Nov 21 11:45:07 2024 -0500 Update manifests commit c6c1406f2367bbad9b30fd1d3f8b0a1531c988d4 Author: James Meng <[email protected]> Date: Thu Nov 21 11:38:10 2024 -0500 Add and update tests Add JSON flag test commit 7dcd1a5ff599241154f6ae2012d61aaf0bd26d14 Author: James Meng <[email protected]> Date: Thu Nov 21 15:34:12 2024 -0500 [Refactor] Cleanup unused conditional commit 1a1b3b18f41a0ee8591624952f651e0c68f9fbce Author: James Meng <[email protected]> Date: Thu Nov 21 11:22:56 2024 -0500 refactor: extract theme check logic and improve strict mode handling commit 3feeac33fa1e0f25787fca0b679ae0414b694340 Author: James Meng <[email protected]> Date: Thu Nov 21 01:09:09 2024 -0500 Add --strict flag to theme push to enforce theme check before pushing commit 34ce42dd91d6a0837c191e57ee8bb69f5aa8ec26 Merge: a1af910e5e d00e41a0d2 Author: James Meng <[email protected]> Date: Wed Nov 27 17:02:10 2024 +0000 Merge pull request #4920 from Shopify/jamesmengo-patch-1 Update CODEOWNERS file patterns and add CLI README commit a2cd0eb951aaedf79f6387a324dbfc5dc2e45998 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 17:53:21 2024 +0100 Fix merge commit 984670ab60d5cffb078e5f717a878b72bbac5bb3 Merge: fdf0d22506 a1af910e5e Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 17:52:28 2024 +0100 Merge branch 'main' into upgrade-pnpm commit 504289fe529e7e2214c581340328aa20a31b3434 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 16:59:20 2024 +0100 Add extra mock commit bd38db39847e390f2c1a5a889175ba99e52ba58b Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 15:53:05 2024 +0100 abort watcher process after each test commit 3b6f7337a8d35f9ca4eadd751e3a411d4d540dee Merge: 274718e511 a1af910e5e Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 15:42:37 2024 +0100 Merge branch 'main' into fix-dev-session-tests-memory-leak commit a1af910e5e8c37e630b5fe3ca85a1d90fa77df34 Merge: a25af5a250 992bf9422e Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 15:32:28 2024 +0100 Improvements to App reload speed (#4924) ### WHY are these changes introduced? Improves app reloading performance by caching or avoiding expensive operations. ### WHAT is this pull request doing? - `~200ms` Introduces a new `reloadApp` function that reuses data from the previous app instance. - `~200ms` Caches JSON schema validators to avoid recompilation on each validation. - `~100ms` Replaces git ignore checking with a more efficient alternative: the `ignore` package - `~1200ms` Improves handling of CLI version warning to only check once per command execution. - Reduces the file-watcher debouncing time to 200ms Before this PR, time to reload an app: `1500-2000ms` New time: `~15-20ms` ❗ Improvement: `100x` ### How to test your changes? 1. Run `dev` on an app with multiple extensions using the app management API. 2. Make changes to extension configuration files. 3. Verify that reloading is faster and the app continues to function correctly. ### Measuring impact - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible documentation changes commit 992bf9422eb45e9ff5d5eb18060e15ea7e4b03d1 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 14:56:04 2024 +0100 Remove global didCheckForGlobalCLIWarning and update debounce to use leading commit f339b3cdeaa28299f69ce53bdec9094f61226d9d Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 13:46:46 2024 +0100 Add more tests for gitTracked commit 271acdb7ff3ab7026f7c868b912ab3164e06cadd Author: Isaac Roldán <[email protected]> Date: Tue Nov 26 12:59:34 2024 +0100 Loader improvements commit 43f0bd5d521ce247430c1ea539dfe98cc85b1fcc Author: Isaac Roldán <[email protected]> Date: Tue Nov 26 12:29:35 2024 +0100 Cache json schema validators commit a25af5a250f92389cd6dd78577d12534685f783d Merge: aecf7fe2bb 3fee076cd6 Author: Alfonso Noriega <[email protected]> Date: Wed Nov 27 14:14:52 2024 +0000 Merge pull request #4877 from Shopify/admin-link-import-transform-url-to-relative on import link extensions make absolute urls relative commit aecf7fe2bb11b8ad875f3686730f000e5d8af3c4 Merge: 55eef10137 9ed8458c4e Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:57:50 2024 +0000 Merge pull request #4930 from Shopify/skip-notifications-with-json-flag Skip notifications when using --json commit fdf0d22506f784ff9df5362e615f24dadeeedcfd Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:50:17 2024 +0100 Update workflows commit 1ac92cc9e406c0bf572755454eba0755e20aea12 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:38:45 2024 +0100 Update get-started.md commit b649a540e38a7b2345a119e6554a432410bd9a16 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:37:15 2024 +0100 Upgrade pnpm to v9 commit 9ed8458c4ec8a040c0aeadf3ae77f9ad57d8608b Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:25:36 2024 +0100 Fix lint issue commit 21d6b33287b3e9f3e10905102eeeae46f92737d3 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 14:04:25 2024 +0100 Keep a single reference of SHOPIFY_FLAG_JSON commit 2ca99425e212e720344240c257843fb5f0548419 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:23:09 2024 +0100 Update documentation commit 740d15d4df309b0108c16ab2450c763e147b99b6 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:19:37 2024 +0100 Refresh manifests commit 8e03a724d8beab1594d9b047a743c47d44782aec Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:10:36 2024 +0100 Add test commit 451c1769ab644ae0d579967723e0379ebcea47fd Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:05:15 2024 +0100 Update changeset commit db0391081e7d70e0696decff47192e5ebcc7bcd2 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 13:03:25 2024 +0100 Skip notifications when using SHOPIFY_FLAG_JSON commit 55eef10137cfab0b386748922f5c03bec9daddd0 Merge: 6a802151a6 0da3319aeb Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 12:56:35 2024 +0100 Fix initial draft update (#4929) ### WHY are these changes introduced? Addresses potential race conditions when pushing updates for draftable extensions in parallel. ### WHAT is this pull request doing? - Filters extension events to only process draftable extensions - Implements concurrent processing of extension updates using `Promise.all` ### How to test your changes? 1. Run dev with multiple draftable extensions (admin-action, theme) 2. Verify that we send initial drafts for every extension. ### Measuring impact - [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix ### Checklist - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've considered possible [documentation](https://shopify.dev) changes commit b47fdc347db7dcd12c80f571f572f27b8a804798 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:52:46 2024 +0100 Unify --json flag across commands commit e67cf3bf5fff4c269b9af3bb6569ac0dc8cad43b Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:52:10 2024 +0100 Skip notifications when using -j commit 5531731c115d9363fc870f721827036424937c84 Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:29:48 2024 +0100 Add changeset commit 40d7edc1b562d1966e3de1bbdd5613c7c45dbb7d Author: Gonzalo Riestra <[email protected]> Date: Wed Nov 27 12:29:10 2024 +0100 Skip notifications when using --json commit 0da3319aeb3bd8d37c625beecc65816ac3edb0c5 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 12:25:42 2024 +0100 Update draftable-extension.ts commit 274718e511ab3d1678ecaf9ec3ba83936fa2ec74 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 12:19:24 2024 +0100 Abort AppWatcher after every test commit 4b4c8756e0870068bfaeb9fe60acfe1322ce9989 Author: Isaac Roldán <[email protected]> Date: Wed Nov 27 11:28:31 2024 +0100 Fix initial draft update commit 3fee076cd6f6a0340521889197c118c734bda37d Author: Alfonso Noriega <[email protected]> Date: Mon Nov 25 15:53:46 2024 +0100 Add missing update imported flag for admin link and subscription link commit e6746ac5372e79fe09a5662dd813c9f547186525 Author: Alfonso Noriega <[email protected]> Date: Mon Nov 25 15:20:08 2024 +0100 Remove All option if only one is imported commit d56b534dd3e898110dcae2be2fb12eee2afed7f9 Author: Alfonso Noriega <[email protected]> Date: Tue Nov 19 11:34:57 2024 +0100 on import of legacy link extensions make absolute urls relative for embedded apps commit b25d93a5eb8c94c3045d790a1681b8a9ffc0dac3 Author: AaronBarcos <[email protected]> Date: Wed Nov 27 10:25:41 2024 +0100 Fix lint error: handle unexpected errors in catch block commit ff994c34d370fe732d7f41c8677546520e8da489 Author: AaronBarcos <[email protected]> Date: Wed Nov 27 10:12:27 2024 +0100 Add changeset for password validation fix commit 5ac28c0c89187e3fed052b988a1149e6552d9799 Author: aaronbarcos <[email protected]> Date: Thu Nov 21 11:27:18 2024 +0100 Enhance storefront password validation to check redirect URL origin commit 501fadf8e98de8e0e1f5fa308f6d93a35fce3946 Author: aaronbarcos <[email protected]> Date: Thu Nov 21 11:25:59 2024 +0100 Add tests for storefront password validation with localized URL and origin checks commit fe1b92e862faa60a0427da574cd34ee5110b9ea8 Author: Cedric Darne <[email protected]> Date: Tue Nov 26 17:02:08 2024 -0500 Add the OrgId to all webhooks API calls The Organization ID is required by the new API to check the various token permissions commit d00e41a0d23e49a0ea7e534a12b132bdfe493ad1 Author: James Meng <[email protected]> Date: Mon Nov 25 12:07:03 2024 -0800 Update CODEOWNERS - Add docs to Advanced edits allow-list - Add subfolders to `docs-shopify.dev` - Update README.md Motivation: Self serve for PR's like https://github.com/Shopify/cli/pull/4900/files where we add a new flag commit 6a802151a6bc01932631c363e6a790b23adc058f Merge: 04d6a2e6ce af2a07d082 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 18:54:12 2024 +0000 Merge pull request #4926 from Shopify/message-field Use message field properly commit af2a07d082eb148abd8253a111547d91d2bb7635 Author: Ariel Caplan <[email protected]> Date: Tue Nov 26 19:11:12 2024 +0200 Use message field properly commit 04d6a2e6ce6f08a3a746b903d387d2d6f41592c4 Merge: ecb0b9d103 928fbe72b4 Author: Shaun Stanworth <[email protected]> Date: Tue Nov 26 18:07:33 2024 +0000 Merge pull request #4923 from Shopify/fix-knip Remove micromatch dependency commit ebca8acc260931d6dd2a1a65395b38ec917feaf9 Author: Cedric Darne <[email protected]> Date: Mon Nov 25 18:12:56 2024 -0500 sendSampleWebhook better null field handling commit c49eb8ac5045a315987cb035c98783e36ff34ca9 Author: Cedric Darne <[email protected]> Date: Mon Nov 25 12:19:50 2024 -0500 Simplify the PublicApiVersions query commit d567c2f246146771ba925a3166baf8433f5a699d Author: Cedric Darne <[email protected]> Date: Fri Nov 15 16:30:50 2024 -0500 Introduce dev dash webhooks API commit 928fbe72b418d528a966fd45cfab60f6b0ca6102 Author: Isaac Roldán <[email protected]> Date: Tue Nov 26 10:33:15 2024 +0100 fix-knip commit 97117a0a8ef3bea19eb8a6b0700bd8a47a92970a Author: Nick Wesselman <[email protected]> Date: Mon Oct 21 11:45:14 2024 -0400 Normalize URL and use hyperlinks commit 6b063d17c1464c9fa36c4ec9ddeeab343f7069eb Author: Nick Wesselman <[email protected]> Date: Mon Oct 21 10:36:40 2024 -0400 Fix the URL output to add a new product commit 5d960d494a32ff3735ce34fa92d3835448e8c997 Author: Surma <[email protected]> Date: Tue Oct 1 14:36:33 2024 +0100 Remove reference to package.json commit a84792f30c81dedd2ff0c6444bb37d8cc6f741e9 Author: Gonzalo Riestra <[email protected]> Date: Wed Sep 25 17:32:11 2024 +0200 Add tests commit 07cd7c1b1388f34c914561539c8b6db7b19a4ba3 Author: Ariel Caplan <[email protected]> Date: Wed Sep 25 14:49:27 2024 +0300 Fix check to enforce everything commit 9c9b8df4ed578f548d222645d023d730e5e9fa88 Author: Gonzalo Riestra <[email protected]> Date: Wed Sep 25 12:32:56 2024 +0200 Avoid errors on checkCommandSafety when the command is not found
WHY are these changes introduced?
When running
shopify theme dev
for long periods of time, the session can timeout and needs to be refreshed. The client will receive 401 errors from the server until the session is refreshed.We've fixed this for REST calls in #4790.
This PR does the same for graphQL calls.
Fixes #4897
WHAT is this pull request doing?
@karreiro and I decided the best way to approach this was to extend the functionality of
retryAwareRequest
so that when a 401 error occurs, and anunauthorizedHandler
is provided, then we call the unauthorizedHandler and retry the request.Further up the stack in the graphQL code, we use the session's refresh function as the unauthorizedHandler.
Checklist