Fix the theme ID mismatch error, where the live theme ID is returned instead of the development theme ID

[karreiro]

WHY are these changes introduced?

Fixes #4634

When the "Sign in with Shop" is activated, the /account endpoint behaves differently (returning the live theme ID in the body) impacting the proxy. However, following the redirect maintains the expected theme ID in the session.

It's important to note that stores without that feature were not being affected by this, and are not affected by this change as well.

WHAT is this pull request doing?

This PR updates the proxy logic to proxy /account requests and avoid the remote-render of the /account endpoint.

This PR also refactors the logic in the proxy to rely on regular expressions to evaluate patterns to centralize the logic for each case on the regular expressions and prevent conditions from growing like p.startsWith(..) && p.endsWith(..).

How to test your changes?

• Run shopify theme dev in a store with "Sign in with Shop" is activated
• Open http://127.0.0.1:9292/account in the browser
• Notice the mismatch error no longer happens

Before

After

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.44% (+0.01% 🔼)	8365/11548
🟡	Branches	68.83% (+0.02% 🔼)	4077/5923
🟡	Functions	71.87%	2197/3057
🟡	Lines	72.74% (+0.01% 🔼)	7911/10876

Test suite run success

1919 tests passing in 872 suites.

Report generated by 🧪jest coverage report action from ec245ae

[EvilGenius13]

Thank you for the fix @karreiro 🥳 . I 🎩 and it works for me as well.

[jamesmengo]

left 1 suggestion for test name brevity. non blocking

[jamesmengo]

This fixes the issue with the server crashing

Aside - clicking sign in with shop opens the modal but doesn't populate any content there. Is this expected?

[karreiro]

/snapit

[github-actions]

🫰✨ Thanks @karreiro! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

[karreiro]

Thank you for the review, everyone!

Aside - clicking sign in with shop opens the modal but doesn't populate any content there. Is this expected?

I was thinking the same thing, @jamesmengo. Currently, that's expected — that's a different limitation in the proxy, as pay.shopify.com won't accept requests from http://127.0.0.1:9292. I think it's reasonable to revisit this in the future, but at the moment, I believe there are workflows in the main path of the CLI that need more attention.