-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use app context in rest of commands #4685
Conversation
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/json-schema.d.ts@@ -2,7 +2,7 @@ import { ParseConfigurationResult } from './schema.js';
import { ErrorObject, SchemaObject } from 'ajv';
type AjvError = ErrorObject<string, {
[key: string]: unknown;
-}>;
+}, unknown>;
/**
* Normalises a JSON Schema by standardising it's internal implementation.
*
packages/cli-kit/dist/public/node/themes/urls.d.ts@@ -3,5 +3,4 @@ import { AdminSession } from '@shopify/cli-kit/node/session';
export declare function themePreviewUrl(theme: Theme, session: AdminSession): string;
export declare function themeEditorUrl(theme: Theme, session: AdminSession): string;
export declare function codeEditorUrl(theme: Theme, session: AdminSession): string;
-export declare function storeAdminUrl(session: AdminSession): string;
-export declare function storePasswordPage(store: AdminSession['storeFqdn']): string;
\ No newline at end of file
+export declare function storeAdminUrl(session: AdminSession): string;
\ No newline at end of file
packages/cli-kit/dist/private/node/ui/components/TextPrompt.d.ts@@ -2,7 +2,7 @@ import { InlineToken, TokenItem } from './TokenizedText.js';
import { AbortSignal } from '../../../../public/node/abort.js';
import { FunctionComponent } from 'react';
export interface TextPromptProps {
- message: TokenItem;
+ message: string;
onSubmit: (value: string) => void;
defaultValue?: string;
password?: boolean;
|
Coverage report
Test suite run success1899 tests passing in 867 suites. Report generated by 🧪jest coverage report action from 34a6fc2 |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
WHY are these changes introduced?
Use the generic app-context for all commands
WHAT is this pull request doing?
import-extensions
webhook trigger
AppLinkedInterface
, meaning that all commands should have a valid app and user always.Remove a bunch of unused functions as a result of the above.
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist