Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During link, use --config to set the toml name #4649

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Oct 15, 2024

WHY are these changes introduced?

Proposal to allow using --config as the value of the toml file name when linking a new app.
Fixes #4590
Fixes #3751

WHAT is this pull request doing?

Take the value of --config as the name of the toml file when linking.
If provided, the CLI won't prompt for a config file name.
If a file with that name already exist, it will overwrite the existing file with the new linked app.

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

@isaacroldan isaacroldan changed the title Use the value from the config flag as the value of the toml name During link, use --config to set the toml name Oct 15, 2024
@isaacroldan isaacroldan marked this pull request as ready for review October 15, 2024 10:24
@isaacroldan isaacroldan requested a review from a team as a code owner October 15, 2024 10:24
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.6% (-0.3% 🔻)
8498/11705
🟡 Branches
69.59% (-0.14% 🔻)
4174/5998
🟡 Functions
71.73% (-0.27% 🔻)
2207/3077
🟡 Lines
72.93% (-0.31% 🔻)
8041/11026
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / authorize.ts
100% 75% 100% 100%
🔴
... / post-auth.ts
44.12% 0% 0% 45.45%
🔴
... / redirect-listener.ts
14.75% 0% 33.33% 15%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / session.ts
81.01% (-1.99% 🔻)
72.32% (-0.41% 🔻)
92.86%
80.67% (-2.09% 🔻)
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1933 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from 1b7072e

@isaacroldan isaacroldan added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit a89a4fe Oct 15, 2024
1 check passed
@isaacroldan isaacroldan deleted the enable-config-name-flag-during-link branch October 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants