Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config commands description in --help #4648

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

Fixes #4552

WHAT is this pull request doing?

Override the description of shopify config and shopify config autocorrect
Since it doesn't have a specific descirption in code, it was automcatically using the description of shopify config autocorrect off

This fixes it to display a more appropriate description when

How to test your changes?

run pnpm shopify config or pnpm shopify config autocorrect to see the changes.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@isaacroldan isaacroldan requested a review from a team as a code owner October 15, 2024 09:30
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.61% (+0.02% 🔼)
8499/11705
🟡 Branches
69.61% (+0.03% 🔼)
4175/5998
🟡 Functions 71.73% 2207/3077
🟡 Lines
72.94% (+0.02% 🔼)
8042/11026

Test suite run success

1933 tests passing in 873 suites.

Report generated by 🧪jest coverage report action from 7f74723

@isaacroldan isaacroldan added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 3970350 Oct 15, 2024
@isaacroldan isaacroldan deleted the update-config-description branch October 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Confusing line in help text
2 participants