Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Shopify/theme-tools packages #3564

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Bump Shopify/theme-tools packages #3564

merged 1 commit into from
Mar 18, 2024

Conversation

charlespwd
Copy link
Contributor

WHY are these changes introduced?

Fixes #3497

WHAT is this pull request doing?

  • Bumps Shopify/theme-tools dependencies
    • Fixes a bug on Windows with shopify theme check not globbing files properly
    • Adds support for JSON intellisense of locales and section schemas to shopify theme language-server

@charlespwd charlespwd requested a review from karreiro March 15, 2024 13:49
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@charlespwd charlespwd requested a review from isaacroldan March 15, 2024 13:49
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 72.48% 6647/9171
🟡 Branches 69.42% 3212/4627
🟡 Functions 71.2% 1758/2469
🟡 Lines 73.7% 6271/8509

Test suite run success

1587 tests passing in 741 suites.

Report generated by 🧪jest coverage report action from b95db46

@charlespwd charlespwd added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 98902f5 Mar 18, 2024
@charlespwd charlespwd deleted the bump/theme-tools-2024-03-15 branch March 18, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

@karreiro karreiro Awaiting requested review from karreiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme check: command doesn't inspect any file after CLI upgrade
2 participants
@charlespwd @isaacroldan