Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop release documentation #2948

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

alvaro-shopify
Copy link
Contributor

@alvaro-shopify alvaro-shopify commented Oct 9, 2023

WHY are these changes introduced?

Drop release documentation and move it to the Team Vault site

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@alvaro-shopify alvaro-shopify force-pushed the doc-to-create-experimental-release branch 2 times, most recently from a2378e5 to 4a405ad Compare October 9, 2023 14:33
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.98% (+1.02% 🔼)
6086/8227
🟡 Branches
71.2% (+1.2% 🔼)
2977/4181
🟡 Functions
72.51% (+0.97% 🔼)
1548/2135
🟡 Lines
75.29% (+1.09% 🔼)
5776/7672

Test suite run success

1447 tests passing in 673 suites.

Report generated by 🧪jest coverage report action from 9f1e407

@github-actions
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@alvaro-shopify alvaro-shopify changed the title How to create an experimental release Drop release documentation Oct 11, 2023
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alvaro-shopify alvaro-shopify added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit e358f1e Oct 13, 2023
@alvaro-shopify alvaro-shopify deleted the doc-to-create-experimental-release branch October 13, 2023 08:29
@shopify-shipit shopify-shipit bot temporarily deployed to experimental October 16, 2023 14:05 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly October 16, 2023 17:10 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production October 19, 2023 13:18 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to stable_3_50 October 31, 2023 18:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants