Skip to content

Add --dev-preview flag to theme init for framework theme support #17502

Add --dev-preview flag to theme init for framework theme support

Add --dev-preview flag to theme init for framework theme support #17502

Triggered via pull request December 20, 2024 19:17
Status Success
Total duration 6m 5s
Artifacts 1

shopify-cli.yml

on: pull_request
[PR] Check OCLIF manifests & readme & docs
2m 19s
[PR] Check OCLIF manifests & readme & docs
[Manual] Test with Node ${{ inputs.node-version }} in ${{ inputs.os }}
0s
[Manual] Test with Node ${{ inputs.node-version }} in ${{ inputs.os }}
Matrix: main
Matrix: pr-acceptance-tests
Matrix: pr-platform-agnostic-bundle
Matrix: [PR] Check graphql-codegen has been run
Matrix: pr-platform-agnostic-knip
Matrix: pr-platform-agnostic-lint
Matrix: pr-platform-agnostic
Matrix: pr-platform-dependent
Matrix: pr-test-coverage
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
[PR] Run knip with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Run knip with Node 18.20.3 in ubuntu-latest
knip stderr: The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
[PR] Run build with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Run bundle with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Run type-check with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
packages/theme/src/cli/commands/theme/init.ts#L59
[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.
[PR] Run lint with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Check OCLIF manifests & readme & docs
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Test with Node 22.2.0 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Test with Node 20.14.0 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Test with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Run Test Coverage with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
[PR] Accept. Test with Node 18.20.3 in ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
jmframework_theme--coverage-report
342 KB