Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed aling-items from service bottom to make sure all service items stay of same height #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milindpatel11
Copy link

when service items have different length of content, one with bigger content is higher and symmetry of service items is gone. removing align-items: center from service bottom aligns all height to biggest content box ( I just commented it out for now). Alternatively, we can do align-items: stretch on .service-bottom OR align-self: stretch on .service-item . Feel free to test these and implement change you like.

Screen Shot 2020-12-12 at 5 28 50 PM

@milindpatel11
Copy link
Author

I commented out instead of deleting. First time contributing to GitHub project. Learned to practice and start writing basic site using your tutorial and thanks for that. I have been making bilingual react sites now using inspiration on a few section from your tutorial and had noticed the service item issue earlier with simple non-react version of this site a few months ago and it notices again with my react version recently, to fix I had to do some debugging and I uses stretch to solve this nd thought it will be good to contribute (though just one line of CSS) to project that I had learned a lot from (specifically on header effects etc). Feel free to accept, reject or suggest something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant