Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relationships when two types start with the same string #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JulienPradet
Copy link

Hi 👋

First of all, thanks for open sourcing this lib !

I've found a bug when working with a JSON API that have both the products and productsearch type. It created a conflict when looking for an ancestry and the products's relationships weren't included although they should be.

Before this PR, json.product.image didn't exist in the test I've added.

Not sure if ; is the best separator here but since there is already : in use I guess it's OK.

@ahinvision
Copy link

Please merge - we are running into the same problem

@csprle
Copy link

csprle commented May 11, 2020

We could use this fix as well here. Please consider merging @SeyZ :)

@Bodasia
Copy link

Bodasia commented Nov 27, 2023

@SeyZ I'm so sorry, could you possibly share the maintenance of this repository with someone else so that someone can develop this package? Thanks.
Also @JulienPradet This pull request fixes the issue but creates another, namely an extra nesting of data, "user": { "id": 1, "profile": { "user": "id": 1, ... }}}.

@Bodasia
Copy link

Bodasia commented Nov 28, 2023

@slimee maybe you have access to resolve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants