Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise conditional compiles & package dependencies #1346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thompson-tomo
Copy link

No description provided.

@mythz
Copy link
Member

mythz commented Apr 14, 2024

Thanks for the big PR! Can you also approve the Contributor License Agreement so we can look at merging this, thanks.

@mythz
Copy link
Member

mythz commented Apr 14, 2024

We don't want to mix whitespace changes with other code changes in the same PR which makes it a huge PR for us to inititally review and and for others later when looking through the code base commit history. If you can remove the whitespace changes we can look at accepting the build symbol changes separately.

For widespread whitespace changes like this we'll look at running a tool like tool like dotnet format ideally from a GitHub action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants