Update ComputeSharp.D2D1.WinUI to AOT-safe CsWinRT #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
optimization 🚀
Sergio0694
force-pushed
the
dev/cswinrt-aot
branch
from
62bcb09
to
a943ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates ComputeSharp.D2D1.WinUI to make the code completely AOT-safe, by leveraging the new API changes in CsWinRT to properly support NativeAOT. Some minor changes were needed around how projection vtables were computed, as well as (thankfully) around how the activation factory for a given WinRT type can be retrieved and cast to some interop interface.
Note
Draft, since CsWinRT is still work in progress, so just testing this locally for now.