Update gitpod to cache_from docker.cdot.systems #3371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
humphd
requested changes
Mar 31, 2022
There was a problem hiding this comment.
Tried this on gitpod, and get:
bash: pnpm: command not found
WARNING: The GIT_COMMIT variable is not set. Defaulting to a blank string.
WARNING: The GIT_COMMIT variable is not set. Defaulting to a blank string.
ERROR: The Compose file './docker/gitpod.yml' is invalid because:
services.nginx.build contains unsupported option: 'ports'
ERROR: The Compose file './docker/gitpod.yml' is invalid because:
services.nginx.build contains unsupported option: 'ports'
[1]- Exit 127 pnpm install
[2]+ Exit 1 docker-compose --env-file .env build $SERVICES
exit
🤙 This task ran as a workspace prebuild
WARNING: The GIT_COMMIT variable is not set. Defaulting to a blank string.
ERROR: The Compose file './docker/gitpod.yml' is invalid because:
services.nginx.build contains unsupported option: 'ports'
bash: pnpm: command not found
You need to bump nginx's volumes and ports one tab-stop to the left so it's in the same level as build vs. under it.
Also, I'm not sure what's up with the pnpm not found bit. cc @DukeManh, @Kevan-Y.
|
I am to blame #2915 We removed Line 1 in 9d86ea7 |
|
It's almost there now, it kinda built but couldn't connect to elasticsearch. Will try the suggested solution of "Use
|
|
This is #3369, we can do what is suggested there and add a |
Should I add the |
DukeManh
requested changes
Mar 31, 2022
.gitpod.Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM gitpod/workspace-base | |||
| FROM gitpod/workspace-node | |||
|
|
|||
| # Installing Node LTS | |||
There was a problem hiding this comment.
Now we are working with workspace-node, you can remove node and docker-compose and nvm installion below
|
I haven't used GitPod for a while now. When I run Telescope, the API server is open on PORT 8443 but I can't hit any service, all give me 404 |
|
Still giving me the same error after adding |
|
The problem above is that the |
sirinoks
added
review: normal
area: autodeployment
|
Hi @TDDR, Just wondering if you're still working on this PR. |
manekenpix
force-pushed
the
master
branch
17 times, most recently
from
94eec21
to
e27efa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #3340
Type of Change
Description
We needed to update the GitPod yaml in order to incorporate the move to docker.cdot.systems based images.
Steps to test the PR
Open up GitPod and see if it works.