Fix Dropdown componentWillReceiveProps to handle setting of state correctly #2521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted when reviewing issue #2375 that the Dropdown was incorrectly calling setState() multiple times in the componentWillReceiveProps. The main issue is that the functions setValue() and setSelectedIndex() both operate on this.state, even though this.state was not updated correctly by the AutoControlledComponent prior to calling them. This fix addresses this by allowing a callback to be invoked to set further state after the AutoControlledComponent has called setState.
yarn test was run with full tests passing.