-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command to run python script to follow first script example #1710
base: trunk
Are you sure you want to change the base?
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (2c7aeb6)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @sadik312 ,
Thank you the PR. Could you please make similar changes to other translated files too.
Thanks,
Sri
Hi @harsha509 , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added README.md files for the examples for:
- dotnet
- java
- kotlin
I have added the file execution command for:
- python
I have also reflected all of the changes in the first_script.en.md
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sadik312 ,
Thank you for the changes. However, there seem to be some conflicts within the PR. Please could you resolve these when you get a chance?
Thanks,
Sri
Hi @harsha509, |
3. Install dependecies using dotnet | ||
|
||
``` | ||
dotnet restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this doc doesn't say/explain on installing and using the dotnet
command. Adding prerequisites on dotnet installation steps could be beneficial. Any thoughts ?
This comment applies for all other lang readme.md!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does seem like a good idea, however, would the prerequisite also need to include steps for installing on different OS's? For instance, one set of steps for MacOS, one set of steps for Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @sadik312 ,
Pointing to this link on Microsoft Learn should be sufficient, as it covers all cross-platform installation steps for .NET
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harsha509,
I have added the Microsoft Learn link and solved the conflict.
Thanks
Hi @sadik312 , Also could you please resolve conflicts! Thanks, |
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
I have added the command to run the selenium file using Python.
Motivation and Context
This was missing from the documentation.
Types of changes
Checklist
PR Type
documentation, enhancement
Description
examples/python/README.md
to provide users with the command to run a Python script, enhancing the usability of the examples.website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
to link directly to the newly added instructions in the examples README, improving the documentation's interactivity and user guidance.Changes walkthrough 📝
README.md
Add Python Script Execution Instructions
examples/python/README.md
line.
first_script.en.md
Link Python Script Execution in Documentation
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
README.