Use .net 8 SDK to run dotnet examples (#1933)

* Use .net 8 SDK to run dotnet examples * And set CDP to v128
SeleniumHQ · Sep 10, 2024 · 4ddb8c1 · 4ddb8c1
1 parent b8096f8
commit 4ddb8c1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/dotnet-examples.yml b/.github/workflows/dotnet-examples.yml
@@ -48,12 +48,12 @@ jobs:
       if: matrix.release == 'stable'
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 6.x
+        dotnet-version: 8.x
     - name: Set up .Net Nightly
       if: matrix.release == 'nightly'
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 6.x
+        dotnet-version: 8.x
         source-url: https://nuget.pkg.github.com/seleniumhq/index.json
       env:
         NUGET_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}

diff --git a/examples/dotnet/SeleniumDocs/BiDi/CDP/NetworkTest.cs b/examples/dotnet/SeleniumDocs/BiDi/CDP/NetworkTest.cs
@@ -4,8 +4,8 @@
 using OpenQA.Selenium;
 using OpenQA.Selenium.DevTools;
 using System.Linq;
-using OpenQA.Selenium.DevTools.V127.Network;
-using OpenQA.Selenium.DevTools.V127.Performance;
+using OpenQA.Selenium.DevTools.V128.Network;
+using OpenQA.Selenium.DevTools.V128.Performance;
 
 
 namespace SeleniumDocs.BiDi.CDP
@@ -16,7 +16,7 @@ public class NetworkTest : BaseTest
         [TestInitialize]
         public void Startup()
         {
-            StartDriver("127");
+            StartDriver("128");
         }
 
         [TestMethod]
@@ -109,9 +109,9 @@ public async Task PerformanceMetrics()
             driver.Url = "https://www.selenium.dev/selenium/web/frameset.html";
 
             var session = ((IDevTools)driver).GetDevToolsSession();
-            var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V127.DevToolsSessionDomains>();
+            var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V128.DevToolsSessionDomains>();
 
-            await domains.Performance.Enable(new OpenQA.Selenium.DevTools.V127.Performance.EnableCommandSettings());
+            await domains.Performance.Enable(new OpenQA.Selenium.DevTools.V128.Performance.EnableCommandSettings());
             var metricsResponse =
                 await session.SendCommand<GetMetricsCommandSettings, GetMetricsCommandResponse>(
                     new GetMetricsCommandSettings()
@@ -130,8 +130,8 @@ await session.SendCommand<GetMetricsCommandSettings, GetMetricsCommandResponse>(
         public async Task SetCookie()
         {
             var session = ((IDevTools)driver).GetDevToolsSession();
-            var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V127.DevToolsSessionDomains>();
-            await domains.Network.Enable(new OpenQA.Selenium.DevTools.V127.Network.EnableCommandSettings());
+            var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V128.DevToolsSessionDomains>();
+            await domains.Network.Enable(new OpenQA.Selenium.DevTools.V128.Network.EnableCommandSettings());
 
             var cookieCommandSettings = new SetCookieCommandSettings
             {

diff --git a/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj b/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
         <GenerateProgramFile>false</GenerateProgramFile>
     </PropertyGroup>