Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] fix bug for appium subclass that sets neither log file nor out… #12696

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

titusfortner
Copy link
Member

…put stream

Description

Allow subclasses not to set either log file or log output

Motivation and Context

Fix appium/java-client#2004

@titusfortner titusfortner requested a review from diemol September 6, 2023 13:25
@titusfortner titusfortner added this to the 4.13 milestone Sep 16, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (8101236) 57.02% compared to head (11f409d) 56.99%.
Report is 4 commits behind head on trunk.

❗ Current head 11f409d differs from pull request most recent head 4ef79bd. Consider uploading reports for the commit 4ef79bd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12696      +/-   ##
==========================================
- Coverage   57.02%   56.99%   -0.04%     
==========================================
  Files          86       86              
  Lines        5322     5325       +3     
  Branches      192      192              
==========================================
  Hits         3035     3035              
- Misses       2095     2098       +3     
  Partials      192      192              
Files Changed Coverage Δ
py/selenium/webdriver/remote/remote_connection.py 53.87% <0.00%> (-0.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit 6ff7f54 into trunk Sep 16, 2023
55 of 60 checks passed
@titusfortner titusfortner deleted the appium_service branch September 16, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null pointer exception from remote DriverService class when outputstream or logfile are not passed.
4 participants