Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set meta in new outlier detectors #830

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mauicv
Copy link
Collaborator

@mauicv mauicv commented Jul 12, 2023

What is this

Sets meta in new outlier detectors

Related: #807
Fixes: #811

@mauicv mauicv requested a review from ascillitoe July 12, 2023 08:42
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #830 (3db572a) into master (8b2dcbb) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   81.86%   81.81%   -0.06%     
==========================================
  Files         159      159              
  Lines       10317    10326       +9     
==========================================
+ Hits         8446     8448       +2     
- Misses       1871     1878       +7     
Impacted Files Coverage Δ
alibi_detect/od/_gmm.py 97.61% <100.00%> (+0.18%) ⬆️
alibi_detect/od/_pca.py 95.23% <100.00%> (+0.36%) ⬆️
alibi_detect/od/_svm.py 97.67% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mauicv mauicv merged commit 28cb562 into SeldonIO:master Jul 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set meta data on all OD
2 participants