Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set locale for some test files #603

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

MichaelChirico
Copy link
Contributor

I was seeing naming mismatch errors without setting locale to C here.

@MichaelChirico MichaelChirico changed the title Explicitly set locale for qtab test file Explicitly set locale for some test files Jun 20, 2024
@SebKrantz
Copy link
Owner

Thanks @MichaelChirico! Wondering what brings me the honor of you making these edits to collapse's testing facilities?

Also wondered, did CRAN force you to do something about

Result: NOTE
  File ‘data.table/libs/data_table.so’:
    Found non-API calls to R: ‘LEVELS’, ‘NAMED’, ‘SETLENGTH’,
      ‘SET_GROWABLE_BIT’, ‘SET_S4_OBJECT’, ‘SET_TRUELENGTH’,
      ‘UNSET_S4_OBJECT’

? I have some of the same notes now.

@MichaelChirico
Copy link
Contributor Author

Wondering what brings me the honor of you making these edits to collapse's testing facilities?

Finally got around to importing {collapse} as a third-party package internally. We have a "unique" testing environment different from CRAN which can dredge up these sorts of edge cases.

Also wondered, did CRAN force you to do something about

We have not submitted to CRAN yet, not sure what will be enforced. Follow along at Rdatatable/data.table#6180 :)

@SebKrantz
Copy link
Owner

Ok, thanks! And cool that collapse can now be used at Google :)

@SebKrantz SebKrantz merged commit b9c2d45 into SebKrantz:master Jun 20, 2024
6 checks passed
@SebKrantz
Copy link
Owner

Probably not the way you'll go about it @MichaelChirico, but for the radixsort I implemented a custom TRUELENGTH/SET_TRUELENGTH, which avoids an ALTREP check that made the function noticeably more expensive: https://github.com/SebKrantz/collapse/blob/master/src/base_radixsort.h.

@MichaelChirico MichaelChirico deleted the patch-2 branch June 21, 2024 05:38
@MichaelChirico
Copy link
Contributor Author

Thanks for sharing! I'd still like to strive to use the public API if possible, let's see how it goes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants