Use tracemalloc for memory measurements. #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5948 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 93 93
Lines 23007 23007
Branches 5017 5017
=======================================
Hits 20657 20657
Misses 1620 1620
Partials 730 730 ☔ View full report in Codecov by Sentry. |
pp-mo
added
the
benchmark_this
⏱️ Performance Benchmark Report: a809e9aPerformance shiftsFull benchmark resultsGenerated by GHA run |
stephenworsley
requested changes
May 13, 2024
stephenworsley
approved these changes
May 16, 2024
There was a problem hiding this comment.
After running the benchmarks in #5946, I'm satisfied that tracemalloc gives a more accurate view of memory for more cases than the current set up. It seems like there are still some potential difficulties with memory benchmarking for some parallelisation setups, but I don't believe any more problems are being introduced. Otherwise, I think this PR looks good to go.
|
Thanks @stephenworsley ! |
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5947
Replaces the current process RSS ("resident set size") based mechanism.
See #5946 for info on how they compare.
N.B. this is hard to test, possibly only takes effect when merged ?
@trexfeathers can you advise? I'm a bit vague on this.