[CI Bot] environment lockfiles auto-update #5918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![scitools-ci[bot]](https://avatars.githubusercontent.com/in/212324?s=60&v=4){kind=small}
github-actions
bot
added
the
benchmark_this
⏱️ Performance Benchmark Report: 424d6adPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 424d6adPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 424d6adPerformance shiftsFull benchmark resultsGenerated by GHA run |
|
FYI I checked the imagetest locally and the failure is not concerning - some text has moved horizontally but only slightly. Note I'm not currently intending to fully address the failures here as I'm working elsewhere. |
|
Regarding the warning in the docs build: This will be fixed when sphinx-gallery/sphinx-gallery#1289 is released, which sounds like it could be soon. Proposed action(Remember that any changes should be made in a new pull request based on this branch, replacing this pull request).
|
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
49f716d
to
c7692f0
Compare
|
sphinx-gallery 0.16 was released yesterday. Still waiting for action to get it onto conda-forge (sphinx-gallery-feedstock). |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
c7692f0
to
c8ea737
Compare
⏱️ Performance Benchmark Report: 51da245Performance shiftsFull benchmark resultsGenerated by GHA run |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
c8ea737
to
7ffdb11
Compare
⏱️ Performance Benchmark Report: 69432ccPerformance shiftsFull benchmark resultsGenerated by GHA run |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
7ffdb11
to
b4fd1ed
Compare
⏱️ Performance Benchmark Report: c7e0782Performance shiftsFull benchmark resultsGenerated by GHA run |
UpdateSphinx#5953 demonstrates an effective fix for the Sphinx problem. Image hashThe imagehash failure is much worse unfortunately. The test result has indeed changed, but iris/lib/iris/tests/graphics/__init__.py Lines 202 to 207 in 25b685c iris/lib/iris/tests/graphics/idiff.py Lines 147 to 148 in 25b685c A possible fix would be to actually save the tests' iris/lib/iris/tests/graphics/__init__.py Lines 215 to 219 in 25b685c |
I'm struggling to believe that it can possibly be that, since the whole point of a BytesIO is to act as a proxy for a file, and according to the C/Linux streams "everything is a stream" principle it really should be entirely equivalent. Is it not more likely that the local results on which idiff works are different from the ones in the CI ? |
No, I can replicate the test result locally. I even inserted a |
Note that the two are identical when running in the current 'official' environment spec that is on |
OK I guess we have to believe it! |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
b4fd1ed
to
16d3838
Compare
⏱️ Performance Benchmark Report: 13721e9Performance shiftsFull benchmark resultsGenerated by GHA run |
UpdateThe graphical error is nothing to do with Subsequent saves do not hit the same bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lockfiles updated to the latest resolvable environment.
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.