Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase AreaWeighted extent tolerance #5462

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Increase AreaWeighted extent tolerance #5462

wants to merge 6 commits into from

Conversation

stephenworsley
Copy link
Contributor

Addresses #5461

stephenworsley and others added 6 commits September 5, 2023 11:47
@stephenworsley
increase area weighted extent tolerance
ad0535c
@stephenworsley
fix tests
aedf415
@stephenworsley
fix tests
870b4fb
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
521a648 
for more information, see https://pre-commit.ci
@stephenworsley
adjust test
714adad
@stephenworsley
Merge branch 'area_weighted_extent_tolerance' of github.com:stephenwo…
3050795 
…rsley/iris into area_weighted_extent_tolerance

* 'area_weighted_extent_tolerance' of github.com:stephenworsley/iris:
  [pre-commit.ci] auto fixes from pre-commit.com hooks
@stephenworsley
Copy link
Contributor Author

It looks like the mdtol behaviour relies on the missing data being explicitly from a masked source. While I believe the new behaviour in _within_bounds would adress #5461, it remains to change mdtol behaviour so that out of bounds and masked areas are equivalent. There should also be additional tests that this equivalence holds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🚴 Peloton
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@stephenworsley