Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua CI #574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Aqua CI #574

wants to merge 1 commit into from

Conversation

ArnoStrouwen
Copy link
Member

@ArnoStrouwen ArnoStrouwen commented Dec 29, 2023

I'm not sure how DiffEqScalar works, since the reported method ambiguity seems like it should be regularly called.
For the type piracy, this can be solved by giving L a type.
If the type is AbstractDiffEqOperator then the method can stay here, but if it is AbstractSciMLOperator then the method should move.

https://github.com/SciML/SciMLBase.jl/actions/runs/7359078663/job/20033302904?pr=574#step:6:728
https://github.com/SciML/SciMLBase.jl/actions/runs/7359078663/job/20033302904?pr=574#step:6:747

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (416ca0a) 30.42% compared to head (cfa45b0) 5.20%.

Files Patch % Lines
src/operators/basic_operators.jl 0.00% 2 Missing ⚠️
src/operators/diffeq_operator.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #574       +/-   ##
==========================================
- Coverage   30.42%   5.20%   -25.22%     
==========================================
  Files          53      53               
  Lines        4030    3994       -36     
==========================================
- Hits         1226     208     -1018     
- Misses       2804    3786      +982     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@time @safetestset "Solution Indexing" begin
include("downstream/solution_interface.jl")
end
@time @safetestset "Symbol and integer based indexing of integrators" begin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone needs to find the time to change all of these to

@time @safetestset "Symbol and integer based indexing of integrators" include("downstream/integrator_indexing.jl")

This is what we agreed on as the right way, and the formatter is fine with it, but we just never got around to it. These kinds of clean up PRs would be a good time to just throw the regex on it.

@ChrisRackauckas
Copy link
Member

Those operators were deprecated and their documentation was deleted long ago. I think it's time to just remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants