improve Vararg checking
#457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code really shouldn't be messing around with function signatures, but if it is, it should do so better. This allows recognizing things like `g(x::Vararg{Vector{T}, N}) where {N, T}`.
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 49.07% 46.52% -2.55%
==========================================
Files 46 46
Lines 3519 3527 +8
==========================================
- Hits 1727 1641 -86
- Misses 1792 1886 +94
... and 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This needs a test. |
ChrisRackauckas
approved these changes
Jun 16, 2023
|
Test failure is real. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code really shouldn't be messing around with function signatures, but if it is, it should do so better. This allows recognizing things like
g(x::Vararg{Vector{T}, N}) where {N, T}.