Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ETD2RK4 exponential integrator algorithm #1661

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Leebre
Copy link

@Leebre Leebre commented May 9, 2022

Development to add a new exponential integrator, ETD2RK4 from Krogstad's 2005 paper. Krylov/non-krylov OOP versions are implemented and seem to be working (although tests are throwing an error). IIP versions still need to be added. First step is calculated using DP5 (which is also 4th-order).

@ranjanan
Copy link

Rename PR to reflect contribution?

@Leebre Leebre changed the title Lee1 Adding ETD2RK4 exponential integrator algorithm May 12, 2022
@Leebre
Copy link
Author

Leebre commented May 12, 2022

Rename PR to reflect contribution?

Done! Thanks for the suggestion :-)


if integrator.iter == 1
# Initialize the first step using Dorm-Prince-5 (also 4th-order)
aij = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally write the tableau in https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/tableaus/low_order_rk_tableaus.jl so it is only initialized once.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YingboMa , sorry for the slow reply. So, I should use one of the tableaus for Dorm-Prince-5 that is already in that file for the first-step initialization? Ok, I will try to make that change and resubmit over the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants