Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _check_and_convert_maxiters to ensure rounding #849

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #848
Add any other context about the problem here.

@Vaibhavdixit02 Vaibhavdixit02 merged commit 870eea8 into master Oct 28, 2024
20 of 26 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the Vaibhavdixit02-patch-1 branch October 28, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epochs calculation should have a floor or ceil to avoid this
1 participant