-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in the extension names #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI-Maintainer Review for PR - Fix typos in the extension names
Title and Description 👍
Scope of Changes 👍
Docstrings 👎
module OptimizationFiniteDiffExt
module OptimizationForwardDiffExt
module OptimizationReverseDiffExt
module OptimizationSparseFiniteDiffExt
module OptimizationSparseForwardDiffExt
These modules should have docstrings describing their behavior, arguments, and return values.
Suggested Changes
- Please add docstrings to the modules
OptimizationFiniteDiffExt
,OptimizationForwardDiffExt
,OptimizationReverseDiffExt
,OptimizationSparseFiniteDiffExt
, andOptimizationSparseForwardDiffExt
to describe their behavior, arguments, and return values. - Please update the description to include details about how the changes were tested.
Reviewed with AI Maintainer
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=======================================
Coverage 10.19% 10.19%
=======================================
Files 41 41
Lines 2451 2451
=======================================
Hits 250 250
Misses 2201 2201
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The casing is better this way, but I don't think I understand why this would make a difference to the precompilation warning? |
I thought you had a typo somewhere causing it because these were all incorrect, so one that was correct would lead to an issue. This didn't solve the issue, but it at least rules out an issue. |
Yeah makes sense. I think the imports are the issue as you pointed out in the issue |
In an extension you're only supposed to import the package or its extensions, not other dependencies. You can grab the dependencies via |
Someone's going to have to handle the filenames manually though I think because just a caps difference isn't showing up in my Git as a change to commit.