New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14 - Ready] Migration guide and fixes to history file #934

Merged

TorkelE merged 34 commits into master from migration_guide

Jul 2, 2024

Member

TorkelE commented Jun 9, 2024

Right now I am creating the migration guide as a hidden page in the documentation, which then can link from e.g. the GitHub home page.

I will also go through the history file and add anything that was missed, fix formatting/writing errors, and improve parts that are a bit short.


          init

4529be4

TorkelE commented

View reviewed changes

docs/make.jl Show resolved Hide resolved

TorkelE added 3 commits

June 9, 2024 16:40


          update history file

332fb31


          minor history file updates


          migration guide code fixes

884cc7f

TorkelE commented

View reviewed changes

HISTORY.md Show resolved Hide resolved

TorkelE commented

View reviewed changes

HISTORY.md Show resolved Hide resolved

TorkelE commented

View reviewed changes

README.md Show resolved Hide resolved

TorkelE commented

View reviewed changes

docs/src/v14_migration_guide.md Show resolved Hide resolved


          Update HISTORY.md

34260b2

TorkelE changed the title ~~[WIP] Migration guide and fixes to history file~~ [v14 - Ready] Migration guide and fixes to history file

isaacsas requested changes

View reviewed changes

Member

isaacsas left a comment

I'd suggest changing the "stable" links to V14 links once the V14 docs are posted. That we the links won't go out of date if we change around the docs later on.

HISTORY.md Outdated Show resolved Hide resolved

HISTORY.md Outdated Show resolved Hide resolved

HISTORY.md Outdated Show resolved Hide resolved

HISTORY.md Outdated Show resolved Hide resolved

HISTORY.md Outdated Show resolved Hide resolved

docs/src/v14_migration_guide.md Outdated Show resolved Hide resolved

docs/src/v14_migration_guide.md Outdated Show resolved Hide resolved

docs/src/v14_migration_guide.md Outdated Show resolved Hide resolved

docs/src/v14_migration_guide.md Outdated Show resolved Hide resolved

docs/src/v14_migration_guide.md Outdated Show resolved Hide resolved

TorkelE and others added 18 commits

June 28, 2024 17:51


          Update HISTORY.md

a13d440

Co-authored-by: Sam Isaacson <[email protected]>


          Update HISTORY.md

c3d848e

Co-authored-by: Sam Isaacson <[email protected]>


          Update HISTORY.md

Co-authored-by: Sam Isaacson <[email protected]>


          Update HISTORY.md

66cd51a

Co-authored-by: Sam Isaacson <[email protected]>


          Update HISTORY.md

d1897c5

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

3d55c45

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

ab2ad80

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

0f4930e

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

c486367

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

13f3fe0

Co-authored-by: Sam Isaacson <[email protected]>


          Update HISTORY.md

0c38ab8

Co-authored-by: Sam Isaacson <[email protected]>


          Update HISTORY.md

236c8c0

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

aa031fc

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

06ff56b

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

af04a85

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

589812f

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

2d1a383

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

a30f105

Co-authored-by: Sam Isaacson <[email protected]>

TorkelE and others added 6 commits

June 28, 2024 18:00


          Update docs/src/v14_migration_guide.md

52fca23

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

4ee1126

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

2e6511a

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

e83139e

Co-authored-by: Sam Isaacson <[email protected]>


          Update docs/src/v14_migration_guide.md

253bd3f

Co-authored-by: Sam Isaacson <[email protected]>


          change wrong statement on convert compelteness

e3e17ce

Member Author

TorkelE commented Jun 28, 2024

Updated. You are correct about completeness and convert, that was a miss-writing that is now corrected. You are also correct regarding the metadata, the full implementation is kept internal, and we only expose the noise_scaling, description, and misc metadata, each which has their own dedicated MTK-style getters.

TorkelE closed this

TorkelE reopened this

TorkelE added 5 commits

July 1, 2024 11:40


          doc code fix

ea51a88


          update tests

5dc4654


          Merge branch 'master' into v14___migration_guide

eba1e76


          test updates

74277db

fix

d6f1588

TorkelE merged commit ae7f623 into master

6 checks passed

TorkelE deleted the migration_guide branch

July 2, 2024 04:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet