-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BifurcationKit test #1101
BifurcationKit test #1101
Conversation
Let’s merge this once MTK releases with your update since then v.4 should work here. You can use |
@vyudu if you want to merge master into this the SciMLBase cap will hopefully allow it to run through to completion. |
@vyudu the doc folder Project.toml needs updating too. |
OK, seems there are now new intialization related errors. That never happened under the old extension so I guess this is something broken by recent updates to the MTK-BifurcationKit extension (or initialization related changes). If someone wants to take a look at what is going on feel free. I think for now I will just plan to disable this extension like we've disabled SI as I don't have the time or capacity to handle these breakages. |
BifurcationKit is broken due to Krylov.jl things, completely unrelated to anything MTK? |
BifurcationKit has fixed everything I believe. The issue now is system-based indexing is broken in some way (maybe related to the recent |
And this CI failure is something else symbolic related: https://github.com/SciML/Catalyst.jl/actions/runs/11859907434/job/33053954257?pr=1101#step:6:1289 |
@vyudu I dropped your new test. It had a parameter that was not used and no value specified which was causing it to fail CI, and the ODESystem test part seems unrelated to BifurcationKit (so while a good test should probably be placed in a different location). If you want to followup if/when this gets merged and modify those tests feel free (I've left them commented out for now). Hopefully adding a parent field to |
Ahh, I see, leaving |
Wrote a test for the dependent parameters for BK from #1095, that can be uncommented once that works