Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BifurcationKit test #1101

Merged
merged 13 commits into from
Nov 15, 2024
Merged

BifurcationKit test #1101

merged 13 commits into from
Nov 15, 2024

Conversation

vyudu
Copy link
Collaborator

@vyudu vyudu commented Oct 29, 2024

Wrote a test for the dependent parameters for BK from #1095, that can be uncommented once that works

@isaacsas
Copy link
Member

Let’s merge this once MTK releases with your update since then v.4 should work here.

You can use @test_broken for now as that would let us know when the test starts working.

@isaacsas
Copy link
Member

isaacsas commented Nov 1, 2024

@vyudu if you want to merge master into this the SciMLBase cap will hopefully allow it to run through to completion.

@isaacsas
Copy link
Member

isaacsas commented Nov 9, 2024

@vyudu the doc folder Project.toml needs updating too.

@isaacsas isaacsas closed this Nov 14, 2024
@isaacsas isaacsas reopened this Nov 14, 2024
Project.toml Outdated Show resolved Hide resolved
docs/Project.toml Outdated Show resolved Hide resolved
@isaacsas
Copy link
Member

OK, seems there are now new intialization related errors. That never happened under the old extension so I guess this is something broken by recent updates to the MTK-BifurcationKit extension (or initialization related changes).

If someone wants to take a look at what is going on feel free. I think for now I will just plan to disable this extension like we've disabled SI as I don't have the time or capacity to handle these breakages.

@isaacsas isaacsas closed this Nov 15, 2024
@isaacsas isaacsas reopened this Nov 15, 2024
@ChrisRackauckas
Copy link
Member

That never happened under the old extension so I guess this is something broken by recent updates to the MTK-BifurcationKit extension (or initialization related changes).

BifurcationKit is broken due to Krylov.jl things, completely unrelated to anything MTK?

@isaacsas
Copy link
Member

BifurcationKit has fixed everything I believe. The issue now is system-based indexing is broken in some way (maybe related to the recent complete changes?).

@isaacsas
Copy link
Member

isaacsas commented Nov 15, 2024

And this CI failure is something else symbolic related: https://github.com/SciML/Catalyst.jl/actions/runs/11859907434/job/33053954257?pr=1101#step:6:1289

@isaacsas
Copy link
Member

@vyudu I dropped your new test. It had a parameter that was not used and no value specified which was causing it to fail CI, and the ODESystem test part seems unrelated to BifurcationKit (so while a good test should probably be placed in a different location).

If you want to followup if/when this gets merged and modify those tests feel free (I've left them commented out for now).

Hopefully adding a parent field to ReactionSystems will fix the symbolic indexing issues.

@vyudu
Copy link
Collaborator Author

vyudu commented Nov 15, 2024

Ahh, I see, leaving ratechange in was sloppy sorry. Will revisit this after merge

@isaacsas isaacsas merged commit 42607e8 into SciML:master Nov 15, 2024
13 checks passed
@vyudu vyudu deleted the BK branch November 15, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants