-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add browsers list, linting plugin and Docs section with supported browsers #1956
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 701907c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
543aa77
to
77b06f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I left a few comments, let me know what you think!
With the current approach, only JavaScript features are linted, right? So if we use CSS features that are e.g. not supported in firefox, we will not know |
we could try out https://stylelint.io/ to lint our CSS, will create a follow up ticket for that. |
data is used to render data in on the home page.
…Eslint plugin (compat). Code will be linted based on supported browsers. Docs now show a section on the homepage listing all supported browsers and versions.
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
c570847
to
0850eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoCa96 If we list supported browsers in our docs, we should also make sure that they are actually working, so e.g. use those browsers and versions in our Playwright tests. What do you think?
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
Relates to #83
Checklist
npx changeset add
if your changes should be released as npm package (because they affect the library usage)