Support --style=file:<path/to/file> for older versions of clang-format #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be supported by clang-format 14 but we can already get it for older versions by manually loading the file and passing the config as YAML string. Adds conditional dependency on the `yaml` package.
luator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using a .clang-format file from an arbitrary location (i.e. does not need to be in the project directory or parent).
This is done by loading the file and passing the config to
clang-formatas a YAML string, i.e. like this:Adds conditional dependency on the
yamlpackage for reading the file.Note that starting from version 14, clang-format supports specifying a file like this on its own. So if you are interested in merging this change, it would probably make sense to extend it a bit to check the version and only load the config like this for versions <14.