Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPA implemented in place. #9

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Erquint
Copy link

@Erquint Erquint commented Aug 1, 2023

This implements IPA for #4, but if you wanna make it an option — I don't have that for you yet.
You might wanna optionify it yourself in a new branch if needed, since I can't tell if I'll jump into that additional frameworky task anytime yet.

@SaphireLattice
Copy link
Owner

Hi! Sorry it’s been so long since you made this PR, it’s been rather difficult to focus on anything for a little while for me. Hopefully doing better now, hah

This is a nice PR in the idea, but I do not feel like everyone has skill to read IPA phonetics. I personally don’t, alas, though something I want to eventually fix.

The point is that this would be really nice to have as an option that people can choose. That and maybe improve the currently bundled set to be at least somewhat comparable in quality, as I am not a native English speaker and have no clue how phonetically accurate this ended up being.

So uh… I think I might have to implement some sort of options/config GUI to get this in a state I would prefer.

@Erquint
Copy link
Author

Erquint commented Mar 20, 2024

No worries whatsoever. I made these changes for my own convenience locally and created this PR as illustration for you in case you decide to make it an option. Ultimately, do what you will with the PR. I don't mind it hanging or anything.

As for confirming verity of the phonemic dictionary, you can check IPA transcriptions of most English words on Wiktionary for comparison. There will be some minute discrepancies, since I did find the developers of Tunic make a number of inconsistent phonetic transcription mistakes themselves and there's a degree of simplified fitting.

P. S. Oh, and sorry for the mess of reverts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants