Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mic icon fixed, added mic on/off sound, added feature to deactivate M… #118

Closed
wants to merge 0 commits into from

Conversation

mondalsurojit
Copy link
Contributor

πŸ“Œ Mic icon fixed
πŸ“Œ Added mic on/off sound
πŸ“Œ Added feature to deactivate Mic after 5 seconds of inactivity

@SamarthKadam please review it. It took some effort to solve, and I hope you will consider marking it as a level-2 gssoc problem atleast. Thank you in advance.

ChatBox.-.Google.Chrome.2024-05-20.18-46-00.mp4

Copy link

vercel bot commented May 20, 2024

@mondalsurojit is attempting to deploy a commit to the samarthkadam's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
chat-box-jyxx βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 23, 2024 7:55am

@SamarthKadam
Copy link
Owner

@mondalsurojit great work but look for the alignment of cancel button it appears to be distored in means of design. Fix it

@mondalsurojit
Copy link
Contributor Author

@SamarthKadam Sir, can you please share a screenshot, so that I can understand the problem in details. Actually, on my pc (maybe for my laptop size), its working fine.

@SamarthKadam
Copy link
Owner

@mondalsurojit just take the alignment of cancel button to the little left

@mondalsurojit
Copy link
Contributor Author

@SamarthKadam Sir, please check once, whether its okay or not...

@SamarthKadam
Copy link
Owner

@mondalsurojit pull the latest fork and make pr

@mondalsurojit
Copy link
Contributor Author

@SamarthKadam I did what you said...

@SamarthKadam
Copy link
Owner

@mondalsurojit please create a different branch and make pr

@mondalsurojit
Copy link
Contributor Author

mondalsurojit commented May 23, 2024

@SamarthKadam So, sir is it merged? Or, did I do any mistake...? And, can you please consider marking it as a level-2 problem😁...please...πŸ™

@SamarthKadam
Copy link
Owner

@mondalsurojit Please make a pr with creating different branch

@SamarthKadam
Copy link
Owner

@mondalsurojit please make the above changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants