Merge with upstream #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async package is quite big (especially v2 with lodash in dependencies). In this diff I replaced it with simple promise flow. https://packagephobia.com/result?p=async
"require" was used in nylas connection to get options from static class properties. In this diff I moved the source of data to separate module which can be imported by any module and refactored static properties with getters and setters to preserve existing behaviour.
Currently types are specified as weak type `{[string]: any }`. Such type
make it quite hard to replace deprecated "request" with something else
(I'm planning to use node-fetch). In this diff I specified all fields
explicitly and made `path` a mandatory field.
Ref #174 Migrating whole library from "request" at once would be quite massive. In this diff I migrated only exchangeCodeForToken to figure out how to test and install dependencies.
This reverts commit 1899716.
Enabling this setting would yield expected behaviour of providing an array parameters that map to a single key.
The `metadata_pair` would be passed in as an object with all the pairs the user wants to filter, and the SDK converts this to the format of `<key>:<value>` for the API to understand the request
I encountered occasional application crashes and traced them back to timeouts coming from the Nylas API. After reviewing the Nylas-SDK, I found the culprit in the `setTimeout` call used to abort the request. It's bad practice to throw an error from `setTimeout` as its `try...catch` blocks will not intercept the error. Instead, these errors will crash the application. `node-fetch` will reject when `controller.abort()` is called, so we don't need to throw from the timeout anyway. Reference: https://jaketrent.com/post/catch-error-thrown-settimeout/ https://nodejs.org/dist/latest-v7.x/docs/api/errors.html#errors_node_js_style_callbacks
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…sent to the API (#571) This PR fixes an issue where the SDK was incorrectly modifying metadata objects before being sent to the API, specifically the metadata keys were being converted to snake case when they should remain unmodified.
* Update CHANGELOG.md * 7.5.2
…lities (#574) * import from crypto rather than node:crypto * Update CHANGELOG.md
This package is currently leaking the `eslint-plugin-import` dev dependency into the production dependencies, thus requiring consumers to have it installed as a dependency.
Since we support EWS as a provider for Custom Auth and Hosted Auth adding this value to our Provider type
This PR adds the attendees field for filtering events.
This PR adds support for buffer type as a file attachment for attachments greater than 3MB and improves the messaging to the end user on when to use the different content types when attaching a file.
This PR fixes the rotate secret function to make a POST call rather than a PUT. Closes #583.
This PR updates the webhook trigger enum with new webhook triggers supported by the Nylas platform. Closes #582.
This PR fixes compatibility issues with ESM brought by the problematic form-data import statement. Fixes #576.
* Update CHANGELOG.md * 7.6.0
* Add support for masterEventID on Events * Add details to changelog * Fix lint --------- Co-authored-by: Subash Pradhan <[email protected]>
* Update changelog.md * 7.6.1 --------- Co-authored-by: Subash Pradhan <[email protected]>
* Add missing select field on query parameter and missing name field on grant model * lint --------- Co-authored-by: Subash Pradhan <[email protected]>
Co-authored-by: Subash Pradhan <[email protected]>
Co-authored-by: Subash Pradhan <[email protected]>
Co-authored-by: Subash Pradhan <[email protected]>
* add config models * add booking models * add comments to the config * changes * add config resource * add sessions resource * add the ability to send a payload with a DELETE * add support for booking endpoints * add scheduler endpoints to nylas entrypoint * lint * Add test case for configuration resources * Fix code formatting for prettier * Fix sessions endpoint * Add test cases for session endpoint * Add test cases for session endpoint * Fix bookings endpoint * Add test cases for booking endpoint, fix types for startTime and endTime on bookingRequest * Fix formatting --------- Co-authored-by: Subash Pradhan <[email protected]> Co-authored-by: Subash Pradhan <[email protected]>
Co-authored-by: Subash Pradhan <[email protected]>
* Fix query parameters for array values We were creating a new snakeCaseKey=item for each item in the value array. This was creating multiple instances of the snakeCaseKey query param if there is more than one item in an array. * Fix test case for updated logic
Co-authored-by: Subash Pradhan <[email protected]>
* Fix Credentials endpoint * Fix lint --------- Co-authored-by: Subash Pradhan <[email protected]>
Co-authored-by: Subash Pradhan <[email protected]>
Co-authored-by: Subash Pradhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Salesflare/Server#4012