Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proxy for downloading libblink_cmp_fuzzy #1030

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

drowning-in-codes
Copy link

The Curl command itself does not use system proxies, so use environment variables to avoid not being able to download the blink libraries in some regions.

The Curl command itself does not use system proxies, so use environment variables to avoid not being able to download the blink libraries in some regions.
@Saghen
Copy link
Owner

Saghen commented Jan 17, 2025

Thanks! I believe we should only support https since we'll never need to download over http. Also add a configuration option fuzzy.prebuilt_binaries.use_system_proxy that enables this behavior (on by default), with a description indicating that it loads your HTTPS_PROXY env when true. It'd be great to also have a fuzzy.prebuilt_binaries.system_proxy_url, which would be a URL to use

@drowning-in-codes drowning-in-codes changed the title add proxy for downloading libblink_cmp_fuzzy fix: add proxy for downloading libblink_cmp_fuzzy Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants