Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Basic Authentication before HTTP RoundTrip #17

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Handle Basic Authentication before HTTP RoundTrip #17

wants to merge 4 commits into from

Conversation

dyhkwong
Copy link

After 76b5f0a, http.Client.Do was replaced by http.Transport.RoundTrip. http.Client.Do handles Basic Authentication automatically, but http.Transport.RoundTrip does not.

@nekohasekai nekohasekai force-pushed the dev branch 4 times, most recently from bda82fb to e88a7cb Compare June 24, 2024 04:13
@nekohasekai nekohasekai force-pushed the dev branch 4 times, most recently from cb35bb0 to f20dc0f Compare July 27, 2024 01:30
@dyhkwong dyhkwong force-pushed the fix-basicauth branch 3 times, most recently from 47dd034 to fde0e39 Compare November 18, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyhkwong @nekohasekai