fix(textarea): ensure that correct height is applied when rows and expandable prop are used together - FE-6810 #6976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures that when the
rows
prop andexpandable
prop are used simultaneously, the textarea component renders with the correct height.fixes #6961
Proposed behaviour
Current behaviour
Checklist
d.ts
file added or updated if requiredQA
Additional context
I have opted to go with a Chromatic snapshot to cover us in the event of any regression happening and reintroducing this bug.
Testing instructions
With expandable and rows in a dialog with form
is sufficient.minHeight
,rows
orexpandable
props are used.