Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): ensure that correct height is applied when rows and expandable prop are used together - FE-6810 #6976

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DipperTheDan
Copy link
Contributor

This fix ensures that when the rows prop and expandable prop are used simultaneously, the textarea component renders with the correct height.

fixes #6961

Proposed behaviour

Screenshot 2024-09-20 at 13 57 22

Current behaviour

Screenshot 2024-09-20 at 13 58 09

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

I have opted to go with a Chromatic snapshot to cover us in the event of any regression happening and reintroducing this bug.

Testing instructions

  • Ensure that the new Chromatic snapshot for With expandable and rows in a dialog with form is sufficient.
  • No other visual or functional regressions with Textarea.
  • No other visual or functional regressions with Textarea especially when minHeight, rows or expandable props are used.

…pandable prop are used together

This fix ensures that when the `rows` prop and `expandable` prop are used simultaneously, the
textarea component renders with the correct height.

fixes #6961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Number of rows is not being applied to textarea
1 participant