Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): translations for france #6975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arvig33
Copy link

@arvig33 arvig33 commented Sep 20, 2024

Proposed behaviour

When Reduce animation effects is activated, on en french site, the loader component displays the following text ‘Chargement en cours'.

Current behaviour

When Reduce animation effects is activated, on en french site, the loader component displays the following text ‘Téléhargement'.
image

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@arvig33 arvig33 requested a review from a team as a code owner September 20, 2024 08:52
Copy link
Contributor

@tomdavies73 tomdavies73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @arvig33, I was just wondering, has this been change been reviewed by someone on the translations team?

@arvig33
Copy link
Author

arvig33 commented Sep 20, 2024

@tomdavies73 Yes, by Christelle Cornen.

@tomdavies73 tomdavies73 marked this pull request as ready for review September 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants