Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(popover-container): rewrite tests to use RTL instead of Enzyme #6973

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

refactor(popover-container): rewrite tests to use RTL instead of Enzyme #6973

wants to merge 2 commits into from

Conversation

Parsium
Copy link
Contributor

@Parsium Parsium commented Sep 19, 2024 •
edited
Loading

Proposed behaviour

PopoverContainer

  • Rewrite Jest tests to use React Testing Library (RTL)
  • Switch the component to use CSSTransition instead of Transition - to ensure animation style changes are detected in RTL tests.

Current behaviour

  • Jest tests are written with the legacy Enzyme library

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

@Parsium Parsium self-assigned this Sep 19, 2024
@Parsium Parsium force-pushed the FE-6621/popover-container-rtl branch 2 times, most recently from 465aa9a to f412cc5 Compare September 19, 2024 16:18
@Parsium Parsium force-pushed the FE-6621/popover-container-rtl branch from f412cc5 to 8407cc2 Compare September 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Parsium Parsium

Labels
In Progress No QA Required No UX QA Required Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parsium