-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert utils & validations from enzyme to RTL #6972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsium
reviewed
Sep 24, 2024
nuria1110
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with James' comments, nothing else from me so happy to approve once they've been addressed.
tomdavies73
force-pushed
the
FE-6790
branch
from
September 24, 2024 15:54
1ca46a2
to
030c6d4
Compare
Parsium
reviewed
Sep 24, 2024
tomdavies73
force-pushed
the
FE-6790
branch
from
September 25, 2024 08:48
030c6d4
to
d2fe953
Compare
Parsium
approved these changes
Sep 25, 2024
nuria1110
approved these changes
Sep 25, 2024
tomdavies73
added
Passed Review
No QA Required
No UX QA Required
and removed
Pending Review
Pending QA
Pending UX QA
labels
Sep 25, 2024
🎉 This PR is included in version 142.11.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Current behaviour
All test files are either written in enzyme and or use poor practices.
Checklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions