Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert utils & validations from enzyme to RTL #6972

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Conversation

tomdavies73
Copy link
Contributor

@tomdavies73 tomdavies73 commented Sep 19, 2024

Proposed behaviour

  1. Renames and re-writes all test and test descriptions of test files which do not contain any JSX.
  2. Fully re-writes and converts all test files which do contain JSX from enzyme -> RTL.

Current behaviour

All test files are either written in enzyme and or use poor practices.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Copy link
Contributor

@nuria1110 nuria1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with James' comments, nothing else from me so happy to approve once they've been addressed.

@tomdavies73 tomdavies73 marked this pull request as ready for review September 25, 2024 08:55
@tomdavies73 tomdavies73 merged commit c5580bb into master Sep 25, 2024
24 checks passed
@tomdavies73 tomdavies73 deleted the FE-6790 branch September 25, 2024 09:08
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 142.11.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants