Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor flat-table and flat-table-row to RTL FE-6592 #6970

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor flat-table and flat-table-row to RTL FE-6592 #6970

wants to merge 2 commits into from

Conversation

edleeks87
Copy link
Contributor

Proposed behaviour

Remaining unit tests converted to RTL
test stories added for chromatic to capture visual regressions

Current behaviour

FlatTable and FlatTableRow unit tests are enzyme

Checklist

  • Commits follow our style guide
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Typescript d.ts file added or updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@edleeks87 edleeks87 self-assigned this Sep 19, 2024
@edleeks87 edleeks87 requested review from a team as code owners September 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edleeks87 edleeks87

Labels
No UX QA Required Pending QA Pending Review Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edleeks87