refactor(accordion): convert test to react-testing-library #6967
Conversation
| expect(loggerSpy).toHaveBeenCalledWith( | ||
| "The `scheme` prop for `Accordion` component is deprecated and will soon be removed." | ||
| ); | ||
| expect(loggerSpy).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
question(non-blocking): If we have only one Accordion component won't the loggerSpy only be called once anyway?
There was a problem hiding this comment.
🤷 I put this in because the description includes the word "once". I'll want to remove that word if I remove that assertion - I don't think it makes much of a difference so happy to do it either way.
There was a problem hiding this comment.
It's fine. I have had a look elsewhere and we've done this same exact assertion with the same kind of wording. Keep it as is which means it'll be consistent.
| expect(screen.getByText("child content")).toBeVisible(); | ||
| }); | ||
|
|
||
| it("mounts collapsed when `expanded prop` is passed as false", () => { |
There was a problem hiding this comment.
nitpick:
| it("mounts collapsed when `expanded prop` is passed as false", () => { | |
| it("mounts collapsed when `expanded` prop is passed as false", () => { |
| expect(screen.getByText("a subtitle")).toBeVisible(); | ||
| }); | ||
|
|
||
| it("does not adds a subtitle when `subTitle` prop is set and `size` is small", () => { |
There was a problem hiding this comment.
nitpick:
| it("does not adds a subtitle when `subTitle` prop is set and `size` is small", () => { | |
| it("does not add a subtitle when `subTitle` prop is set and `size` is small", () => { |
| const loggerSpy = jest.spyOn(Logger, "deprecate").mockImplementation(() => {}); | ||
| const consoleSpy = jest.spyOn(console, "error").mockImplementation(() => {}); |
There was a problem hiding this comment.
suggestion (non-blocking): We could set up and tear these down in the relevant tests instead to ensure we are only silencing the console when necessary, prevents other console warnings from being masked.
robinzigmond
force-pushed
the
FE-5027-accordion-rtl
branch
from
bf815ad
to
e1bc29d
Compare
|
🎉 This PR is included in version 142.11.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed behaviour
Accordion component unit tests should use React Testing Library
Current behaviour
Tests use Enzyme
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions